Krinkle
Joined 29 October 2012
Latest comment: 8 years ago by Fomafix in topic AnonymousI18N
Common.js updates edit
Looks like there are some characters that didn't paste in right. Could you fix that? --Izno (talk) 22:53, 26 February 2014 (UTC)
- Are you sure those characters are broken? I assume you're referring to some language names that may now appear as squares or question marks. I double checked that these are not broken, you simply don't have a font installed to render them (or, more likely, you have a font available but that font isn't applied to the diff viewer since that uses a code font). If you look closely you'll see that those characters weren't rendered for you before this change either, they rendered as
"\u0710\u072a\u0721\u071d\u0710"
which is an escape sequence that renders to"ܐܪܡܝܐ"
(non-code font: "ܐܪܡܝܐ"). I believe the actual data is unchanged (no more or less broken than before). Now, of course, it's very well possible there is still something broken, but I'll need to see an end-user problem (e.g. someone who's using this information that was able to see his language name before but not anymore). Krinkle (talk) 12:30, 27 February 2014 (UTC)- Oh, you're probably right to say that I have the issue. Thanks. --Izno (talk) 22:48, 27 February 2014 (UTC)
wpAvailableLanguages edit
You moved the definition of wpAvailableLanguages
from anonymous users to all users in MediaWiki:Common.js. commons:MediaWiki:AnonymousI18N.js uses wpAvailableLanguages
, but it is only loaded for anonymous users. Is wpAvailableLanguages
used some where else? --Fomafix (talk) 18:08, 7 March 2015 (UTC)
AnonymousI18N edit
I removed AnonymousI18N in MediaWiki:Common.js because it generates a problem. See MediaWiki talk:Common.js#commons:MediaWiki:AnonymousI18N.js breaks some UI feature. I guess this bug in commons:MediaWiki:AnonymousI18N.js can fixed by replacing
// Prevent the default linking functionalty and instead use getUrlForLanguage()
e.preventDefault();
location.href = AnonymousI18N.getUrlForLanguage(href_full, wgAnonUserLanguage);
by
// Replace href
this.href = AnonymousI18N.getUrlForLanguage(href_full, wgAnonUserLanguage);