User talk:Magnus Manske/missing props.js

Could not determine item type

See

1. Q114808 Hans Dama · available at de.Wikipedia
2. Q15055703 Chava‏ Pressburger · without WMF page
3. Q15056677 Peter-Dietmar Leber · without WMF page

What does "Could not determine item type" mean?
I used only one line in my "common.js" User subpage

importScript( 'User:Magnus_Manske/missing_props.js' );

Please include some sample values for sample pages. Thanks! לערי ריינהארט (talk) 12:29, 10 October 2013 (UTC)

compatibility with authority control.js

Should it work together with authority control.js? לערי ריינהארט (talk) 12:29, 10 October 2013 (UTC)

Adding compatibility with professions

I made a list of profession properties if you want to include it in your script. Would change my life :-) https://www.wikidata.org/wiki/Wikidata:Occupations_and_professions_task_force/Properties --Teolemon (talk) 23:37, 2 November 2013 (UTC)

Bug

Pressing on suggestion property doesn't do the right thing. Opera, Windows. Infovarius (talk) 12:25, 22 January 2014 (UTC)

Works vs editions

Hallo Magnus, bei Bücher unterscheidet WD (lt. Help:Sources) zwischen book (Q571) (z.B. Die Abenteuer des Pinocchio) und version, edition or translation (Q3331189) (Hippeltitsch's Abenteuer, dt. Übers. von 1905). Kannst du Q3331189 zu dem Script hinzufügen und Eigenschaften wie edition number (P393) und place of publication (P291) dorthin verschieben? Thanks --Kolja21 (talk) 21:28, 23 January 2014 (UTC)

Ich habe die Unterscheidung bei User:Magnus Manske/missing props.js/help eingetragen. Du kannst die Daten von dort übernehmen, s. auch Template:Book properties. --Kolja21 (talk) 10:36, 23 February 2014 (UTC)

TypeError

I get the following error when using your script. This kind of error is annoying because it tends to stop execution of all other scripts. I did not dug deeper into this, yet. Sorry. Tested with Opera 12.

[06.05.2014 10:34:45] JavaScript - https://www.wikidata.org/wiki/Q16722397
Event thread: readystatechange
Uncaught exception: TypeError: Cannot convert 'self.claims' to objectError thrown at line 228, column 5 in <anonymous function: determineType>(dummy, tp) in https://www.wikidata.org/w/index.php?title=User:Magnus_Manske/missing_props.js&action=raw&ctype=text/javascript:
    if ( undefined === self.claims[self.p_prefix+tp[0]] )
called via Function.prototype.call() from line 388, column 6 in <anonymous function: each>(obj, callback, args) in https://bits.wikimedia.org/www.wikidata.org/load.php?debug=false&lang=de&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140506T034423Z:
    if (callback.call(obj[i], i, obj[i++]) === false)
called from line 227, column 4 in <anonymous function: determineType>(type, tl) in https://www.wikidata.org/w/index.php?title=User:Magnus_Manske/missing_props.js&action=raw&ctype=text/javascript:
    $.each ( tl , function ( dummy , tp ) {
called via Function.prototype.call() from line 381, column 6 in <anonymous function: each>(obj, callback, args) in https://bits.wikimedia.org/www.wikidata.org/load.php?debug=false&lang=de&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140506T034423Z:
    if (callback.call(obj[name], name, obj[name]) === false)
called from line 226, column 3 in <anonymous function: determineType>(d) in https://www.wikidata.org/w/index.php?title=User:Magnus_Manske/missing_props.js&action=raw&ctype=text/javascript:
    $.each ( self.types , function ( type , tl ) {
called via Function.prototype.apply() from line 610, column 5 in <anonymous function: jQuery.Callbacks>(data) in https://bits.wikimedia.org/www.wikidata.org/load.php?debug=false&lang=de&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140506T034423Z:
    if (list[firingIndex].apply(data[0], data[1]) === false && options.stopOnFalse)
called from line 708, column 7 in <anonymous function: fireWith>(context, args) in https://bits.wikimedia.org/www.wikidata.org/load.php?debug=false&lang=de&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140506T034423Z:
    fire(args);
called from line 5418, column 5 in done(status, nativeStatusText, responses, headers) in https://bits.wikimedia.org/www.wikidata.org/load.php?debug=false&lang=de&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140506T034423Z:
    deferred.resolveWith(callbackContext, [success, statusText, jqXHR]);
called from line 5887, column 8 in <anonymous function: callback>(_, isAbort) in https://bits.wikimedia.org/www.wikidata.org/load.php?debug=false&lang=de&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140506T034423Z:
    complete(status, statusText, responses, responseHeaders);
called from unknown location in program code:
    /* no source available */

--Thiemo Mättig (WMDE) 08:45, 6 May 2014 (UTC)

addOnloadHook is deprecated

Not a real problem currently, it just triggers a little warning in the console which confuses people (e.g. in bugzilla:64842). In case you don't know, PerfektesChaos created this really helpful overview: de:Wikipedia:Technik/Skin/JS/Obsolet#addOnloadHook(). --Thiemo Mättig (WMDE) 08:56, 6 May 2014 (UTC)

Gadget broken?

The gadget seems to be broken. :( — Ayack (talk) 11:20, 24 May 2014 (UTC)

I don't know how it worked, since I installed it yesterday, but now it only displays the missing props, but clicking on one only goes back to the item, without adding any claim... --Hsarrazin (talk) 07:18, 28 May 2014 (UTC)

@Magnus Manske: could you please have a look on this? Sjoerd de Bruin (talk) 09:46, 28 May 2014 (UTC)

Quite the same for me: clicking on prop simply deletes it. --Infovarius (talk) 15:46, 28 May 2014 (UTC)

The same for me. --Accurimbono (talk) 07:42, 3 July 2014 (UTC)

I recently added this gadget and it's not working for me either. - PKM (talk) 17:17, 18 October 2014 (UTC)

Adding new properties

Hello Magnus,

For P31:Q5 (person), could you please add given name (P735) and family name (P734) ? so that it would be easier to notice they are missing :)

thank you very much for this tool, even if it is not very easy to guess how it works :) - I finally managed to use it : clicking on "Add" then the property I want to add...

One difficulty though... when you add a property from the list, all properties listed below it simply disappear from the list… the only way to avoid this is to add properties backward (from bottom to top of the list).

If you could manage to improve the interface, it would probably be much easier to use… perhaps something like a floating box ? --Hsarrazin (talk) 20:10, 6 October 2014 (UTC)

Does not do a thing

It simply does nothing. I have tried on several pages, when you hover over it it displays only "javascript;;" on the link, and when clicked does not do a thing. I have installed it here https://www.wikidata.org/wiki/User:Jjmerelo/common.js --J. J. Merelo (talk) 18:27, 11 February 2017 (UTC)

Same here. JS-Console shows "TypeError: v.labels is undefined". -- MichaelSchoenitzer (talk) 14:38, 5 May 2017 (UTC)