Module talk:Cycling race/archive4

Diverse remarks

Hi everyone, I have been using the different modules of cycling race for some time now and have different remarks in order to improve it:

• About the list of stages, it works fine. I saw in Route de France féminine 2012 a version of the table with mention of the number of starters and finishers. I found it useful, and surely easy to implement. What do you think about it?
• About the Palmarès. Always for the Route de France, there was no 2010 edition. If I insert the palmarès with cycling race, the absent year is not mentioned : see Route de France féminine. It is not too important but still. A "no race" would be nice.
• In the infobox, when there is a prologue, it is not written prologue+n stages but (n+1) stages. Any solution?
• About the property p242 (map). a) It should be possible to insert a legend as for image, otherwise it is impossible to link the colors with the laps. b) In most of the maps there is a legend... in a language. It means that if the map is common for all WPs the language will be wrong for almost all of them. Maybe a facultative language parameter for the map could be useful. Otherwise, it should be possible to insert manually a different map in the infobox.
• If the rosters is inserted with wikidata, we have to be aware that some racers come and leave the teams during the year. It has to be clearly indicated in the table (maybe the insertion of a facultative column "date of arrival"... could solve the problem).

I hope it helps. (contact me on WP:fr for answer, if any). Psemdel (talk) 18:48, 24 April 2016 (UTC)

I have written a comment at frWP. --Molarus 21:48, 26 April 2016 (UTC)

@Psemdel: "About the Palmarès" It is now possible to add a row into the palmares-table. It could look like:

{{Cycling race/listofwinners|Q1642267

| above row 6: any text you want

}}

"some racers come and leave the teams during the year": You may have already seen that it is possible to add such time data. If not, see the example at this page. It should not matter if you add the time data at the saison item or the rider item. But the time data at the saison item has the higher priority. --Molarus 21:14, 20 September 2016 (UTC)

Classifications 2

• I think, missing is still stageclassification, the official name of the team at the time of the race and a lot of data (translations for time, more jerseys, more background colors, gender number for languages other then fr, ..)
• I think the space between number and "+" is correct, because this way it means "add", without it just says that it is a positive number.
• "équipe du Royaume-Uni espoirs de cyclisme sur route 2015" We can´t just write the name of the country, because there is an article in frWiki which has this name, therefore this is a wikilink to that french article. There is a frWiki article about "Équipe nationale de France espoirs" but none about "Équipe nationale du Royaume-Uni espoirs". I think, if there is no such item, we will add the item of the country to indicate a national team. Maybe it is possible to create an alias name like "Royaume-Uni espoirs (m/f)" (there is a problem with d´, du or de in french), in english "Great Britain under 23 (m/f)" and in German "Großbritannien U23 (m/f)". "m" is for men, "f" for female. Maybe also for a team that has no item. There are more national team types (men - female, youth and normal team).
• --Molarus 23:34, 19 June 2016 (UTC)

Yes, it lacks the time for stageclassification. On LV Wiki, DA Wiki, CS Wiki, EN Wiki, IT Wiki, CA Wiki, HU Wiki, we have 84h 46' 14" ; 81ч 57' 45 for RU Wiki and MK Wiki ; 1 o 00 min 12 s for EU Wiki ; 1 h 00 min 12 s for FR Wiki, LB Wiki and ES Wiki ; 84u46'14" for NL Wiki ; 84t 46' 14" for FO Wiki. I will see for the others when I will give them the function, idem for ranks numbers. Fore jerseys, I will create them one by one, and I can modify the code to add background colors (it is easy for me). I should have done this, but I have had a peak of work this week end, that also explain because I was not in race yesterday.

The space is correct.

Maybe it is possible to test by writing Royaume-Uni espoirs, Großbritannien U23. We don't need to write if it is a team for men or women because races are only for men or for women. Jérémy-Günther-Heinz Jähnick (talk) 10:44, 20 June 2016 (UTC)

Can you put the tables for classifications at 90 % for the texts ? I try to do it, but it doesn't work. Jérémy-Günther-Heinz Jähnick (talk) 09:28, 21 June 2016 (UTC)

Finally no, it is better at 100 %. But can you make bold the line of the winner ? Jérémy-Günther-Heinz Jähnick (talk) 10:43, 21 June 2016 (UTC)

I have copied function generalclassification to function stageclassification, changed the property and deleted the background color for the winner. The new code is at WDWiki and I have tested it at frWiki. There should be no error. Next step will be the problem with the national teams. --Molarus 02:19, 22 June 2016 (UTC)

Jérémy, I have the first version at Module talk:Version 2. In frWiki you will see the red link to "France espoirs" and "Germany espoirs" as blue, while "Royaume-Uni espoirs" is red. "France espoirs" links to "Saison 2015 de l'équipe de France espoirs de cyclisme sur route" and "Allemagne espoirs" to the french article Germany. At the moment in frWiki and WDwiki " espoirs" is added behind the country name, while in all other wikis it is " U23". Could you say something about the first version. Can I go on with this?

And I have found an error at number 8, because this rider has no team data for 2015. I have corrected that in the code, but it means there might be more errors like this. For example no p54 (team) at all or no p27 (nationality). I shouldn´t forget to test those things. Molarus 04:18, 23 June 2016 (UTC)

For the nationality, it become very rare that we don't have entered this information, but I sometime have cases. For teams, we will have regularly the case because it is a very long process.

espoirs or U23 is a good idea. Thank you again a time. Jérémy-Günther-Heinz Jähnick (talk) 14:29, 23 June 2016 (UTC)

I have found another problem, see Q20727992 for Marco Mathis. This rider has P54 (team) Germany, but this way we can´t say if the rider is a member of the équipe cycliste nationale or équipe cycliste nationale espoirs. This information is now added with a P31 (is a) and Q20738667 (équipe cycliste nationale espoirs) or Q23726798 (équipe cycliste nationale). The difference is that a "espoirs"/"U21" is added to "Germany" or not. I have tested that and I think it works.

I have moved the code to WDwiki and frWiki and will now start testing with adding some classment data into several items. So far I have tested the code in deWiki and frWiki with two tables at my user page. Both tables looked the way they should, therefore I don´t think there are big errors in the code. See fr:Utilisateur:Molarus --Molarus 09:43, 24 June 2016 (UTC)

We have one item by season team, so it is not correct to add Germany.

I think that if for stage classification (P2417) we have a statement for general classification of race participants (P2321), the code don't finish by a BR. If we don't have general classification of race participants (P2321), we can finish by a BR. See at fr:Tour de Wallonie 2015, for the last stage, we add a code CLR (similar to BR). The idea is to do that automaticly, this way it will be easy for users to copy and paste an article.

I have a problem with teams on FR Wiki, see fr:Halle-Ingooigem 2016. There is no longer links. On another point, Anthony59999 ask if it is possible to have the links to the seasons (thanks to has part(s) (P527)). On my side, but I can make a mistake, I think it is not again possible because we don't have systematicly start time (P580) and end time (P582) for all items about seasons (but it is just a question of time). Jérémy-Günther-Heinz Jähnick (talk) 14:07, 24 June 2016 (UTC)

1) At least at the moment there is no season national U23 team for Germany, but if we will have them and someone add that into the data, there is no need to add the item for a country. I´m not sure if I should delete the code for that already, it is a fallback. -> Q24790438 (équipe d'Allemagne espoirs 2015)

2) I don´t understand that. What does BR and CLR mean?

3a) Yeah, the wikilinks are gone. -(( I will look into that.

3b) something like "Etixx-Quick Step (2016)" in the classification table for a 2016 race? Why not? If we don´t have the time data for that or the season article, then we don´t show that link.

--Molarus 14:48, 24 June 2016 (UTC)

I don't know, surely breakdown and clear. </ br> and {{clr|left}}.

No, something like [[Saison 2016 de l'équipe cycliste Etixx-Quick Step|Etixx-Quick Step]] if in the Wikipedia we have an article for the season. It would be interesting because at the beginning of seasons, we don't have a big number of articles about seasons teams. So when an article will be created, links will automaticly lead to the 2016 article season. Some little Wikipedias will start to have articles about seasons, but little to little. Jérémy-Günther-Heinz Jähnick (talk) 11:42, 25 June 2016 (UTC)

I would say in frWiki the team article is about the history of the team, while the season article is more important. As far as I have seen, at deWiki season articles are data from the last season moved out of the team article. That is true for nlWiki too, imho. Maybe we could show the season article (if available)) only at frWiki and who wants to join (opt in)?

You are speaking about "Modèle:Clr". Have a look at Module talk:Version 2. I had to change the behavior of the tables, because I couldn´t put two tables on the same line. I have changed that by adding a "float:left" to the "Classement de l'étape" and a clr to "Classement général". The problem with that is that I have to add a clr under the single "Classement de l'étape" in the article or the text would float around the table and might this way destroy the look of the article. At the moment, I see no way around that, it is not the optimum. Maybe I´m going to have a better idea until Monday. Molarus 14:21, 25 June 2016 (UTC)

Good idea for the opt in. It is true that it will be interesting to see how the Wikipedias evolve with the functions, and if users start to dispatch datas about teams in small articles.

Thank you, the result is perfect. Jérémy-Günther-Heinz Jähnick (talk) 07:58, 26 June 2016 (UTC)

Maybe editors are going to have more time to write text, but writing text is more difficult then writing tables. For example we have discussed at deWiki about the 9. stage of the Tour de France. What is fr:Ordino-Arcalis? I think, the riders will ride the whole Carretera d´Arcalis or CS-380 to the end, near the french/andorra border. At google map the end of the stage is there, I think. At least the coordinations in Q546015 are no help. I am used to look into google maps when writing wikipedia articles about far a way places. It helps to understand the topic. --Molarus 11:20, 27 June 2016 (UTC)

Ordino-Arcalis is a ski resort (Q130003). We can compare this to a town.

I think that some users are naturally good to write texts and others are naturally good to play with datas. On FR Wiki, we have users that are able to write good articles. The idea is they can spend their time by writing when others will enter datas. Jérémy-Günther-Heinz Jähnick (talk) 12:12, 27 June 2016 (UTC)

For CLR, I have an example here : fr:The Women's Tour 2016. This is why I develop the idea to play with a parameter IF.

I have added a clr, but the main problem in that article is that the code stopped after 10 seconds halve done. That article has 12 lua functions, that is to much.

The code for the saison article works at Module talk:Version 2, but it would make the code even more slower.

Something has to be done??? --Molarus 13:24, 27 June 2016 (UTC)

It is time the Fundation make an evolution for their websites.

For the rest, I will se after. I must leave my desk in few minutes. Jérémy-Günther-Heinz Jähnick (talk) 13:28, 27 June 2016 (UTC)

An idea for tomorrow, we could delete the country names. --Molarus 13:30, 27 June 2016 (UTC)

I have switched the country names off (line 248 and 249) and the time is only 3-4 seconds. For the country names the code has to go to items like France. I have done this at frWiki and WDWiki.

I have also tested the code with the saison article and got 507 expensive calls, only 500 are allowed. And there seems to be an error somewhere. I will look into the code if I could write the code for the saison articles better, but if I can´t improve this problem a lot I would say the new feature is cancelled. --Molarus 14:55, 27 June 2016 (UTC)

The error was because I have deleted the country items. I can´t do that, because I need the country names for the national teams. I have a solution you will not like: In Q21705192 (France espoirs) there is property P1998 (UCI-Code). We could give the team the label "FRA U23". Writing the names into the code would mean, writing 300 country names * 20 Wikis. Too much. And I propose to move the flags in front of the names. --Molarus 16:05, 27 June 2016 (UTC)

I have improved the code to run (now!) in 7 seconds (with country items) in tests. I can improve the code further. If in one table there are 3 riders from Italy, I don´t have to go 3 times to the country item to get the same data. The same is possible for the team data. I have done that already for the flags weeks ago. Maybe this way we could win more seconds and reduce the number of expensive function calls below 500. A really big step ahead would be to use the data from the first tables in all the other tables too, but I have tried to code that weeks ago for the flags and it was not possible.

The situation is this, I think: With further optimization we could reduce the time with country names in good times to 5 seconds and in bad times it is still above 10 seconds (and lua would crash). Without the country names it would be always 3 - 4 seconds. With the saison articles in good times we would have maybe 300-400 expensive calls, in bad times more then 500 calls (and lua would crash) and the number of saison articles will increase over time. A break through would be to use the data from one table in other tables too, but I don´t know if that is possible. I don´t think we have to decide that all now, since at the moment there are not many articles like "The Women's Tour 2016". Maybe you will discuss that with editors in frWiki?

Thinking out of the box: We could change the code so that one call of the module prints always a stage and a general table together if available in the item. Stage items always have both tables, while single stage races have no stage table and wouldn´t print a stage table. The new name of that function could be "classification". In "The Women's Tour 2016" the number of module calls would be reduced by 4 and the clr wouldn´t be necessary anymore. This way, further optimization would work better.

Molarus 05:24, 28 June 2016 (UTC)

Ok for your last proposition, but I need a function in more and not a replacement. I explain : for races as the fr:3e étape du Tour de France 2015, we have one article by stage, so we must have in a part of the article stageclassification and in the other part generalclassification. We have this case for the three main stage races, so it concern around 60 articles by year. For all the other cases, we can have a function stage&generalclassification. The name is longer, but I prefer because as you can see on the link previously quoted, there are other classifications for sprints, climbs, teams, youngs... I will surely launch the proposal for these classifications at the end of the week. Jérémy-Günther-Heinz Jähnick (talk) 07:50, 28 June 2016 (UTC)

For the 3e etape of the TdF 2015 the lua code would crash, while the article now needs only 1 second to run. Maybe we have reached the limits of WD/Lua. Now I don´t know how to go on with classification tables. Maybe we should limit this module to races where not ~10 classification tables with ~1 second runtime per table are needed until better hardware and software is available? --Molarus 09:58, 28 June 2016 (UTC)

It is not a problem. We will let problems and ask to the Foundation they adapt the website. Wikipedia has now 15 years, it is time they think at its future. Jérémy-Günther-Heinz Jähnick (talk) 10:31, 28 June 2016 (UTC)

Classifications 3

This is a proposal even more out of the box. Article fr:3e étape du Tour de France 2015 has two sections showing classifications: Résultats and Classements à l'issue de l'étape.

We could show all 13 classification tables of this article in two module calls. This could look like this:

== Résultats ==

{{#invoke:Cycling race|classification

|Heading3 = Classement de l'étape

|Classement d'étape = Q123

|Heading3 = Points attribués

|Classement intermédiaire = Q33333

|Classement intermédiaire = Q44444

|new line

|Heading4 = Bonifications à l'arrivée

...

}}

== Classements à l'issue de l'étape ==

{{#invoke:Cycling race|classification

...

}}

The recycling of country names, rider names, team data, .. would be the main feature of such a lua function. We could test such a function classification by calling maybe 10 tables generalclassification and stageclassification and adding lots of different headings and new lines. At the moment, I don´t know how to code an efficient mass recycling of data. It would mean maybe additional 1 or 2 weeks to test if such a code really helps us to manage ~10 classification tables in one article. After that I would need the time to code the other classification tables. Molarus 04:22, 29 June 2016 (UTC)

Is it possible in the next days to adapt the code to take the season 2016 for classifications when we have such articles ? The Tour de France will start. Note that I will do few test, I have much work this summer. Jérémy-Günther-Heinz Jähnick (talk) 11:03, 30 June 2016 (UTC)

It is not possible to get that code for the Tour de France. And I have to test beforehand that this new approach doesn´t run into other lua/wd limitations. --Molarus 12:52, 30 June 2016 (UTC)

Ok, no problem. I will start to give functions for classifications at other Wikipedias this afternoon. This way I will have translations in more. Jérémy-Günther-Heinz Jähnick (talk) 07:40, 1 July 2016 (UTC)

Execution time

Hi, sometimes on the article The Women's Tour 2016, I get the loading error " Le temps alloué pour l’exécution des scripts a expiré." (script execution time exceeded) at the end of the article instead of the tables and the referecences. Sometimes it is ok. Any solution? Code optimization needed? Psemdel (talk) 08:39, 3 July 2016 (UTC)

What consumes so much time is the names of the countries (around 3-4 seconds), but even if that is deleted out of the code (I have tested that), there is still the limit of 500 expensive lua function. The article "The Women's Tour 2016" needs 507 of them. In section "Classifications 3" at this page, I have proposed an alternative which maybe improves the situation, but I have not tested that to be sure it is worth the time to code that. And I don´t know if editors would accept such a solution. Until then, I would say, that ~10 lua module calls in one article is to much at the moment. --Molarus 09:57, 3 July 2016 (UTC)

Oh haven't seen that. It is a big issue. Maybe we should ask to increase the limit of 500 expensive lua function? I had also the idea of kind of "cache". So the function could be called once at the generation of the table, save the result in a "normal" shape (no wikidata). The update can take place every, I don't know, day for instance. It is just an idea. Psemdel (talk) 11:09, 3 July 2016 (UTC)

The solutions is to ask to increase the limit of 500 expensive functions. And it become very logic because event the mobile phones evolve each year, so there is no reason that we continue to work with such limitations. Jérémy-Günther-Heinz Jähnick (talk) 13:00, 3 July 2016 (UTC)

If we want to add the annex classification and the start list with wikidata also in the race article, it is clear that just an optimization of the code can't be sufficient. To come back to my "solution", which I explained with very unclearly. The idea is that there is no need for the article to be updated everytime someone load the page. The race is finished, the classification shouldn't evolve. From this statement, it becomes possible to imagine, that as creator we type "{{cyclingrace...}} and that creates (generates) a table in normal wikipedia code so: wikitable.... A comment could let bots know that it was automatically generated and therefore "update" the tables every week for instance. Only disadvantage : if someone edit directly in the wikipedia code, his change will be overwritten. Big advantage : the lua code must be read only once a week. Psemdel (talk) 15:15, 3 July 2016 (UTC)

Non, on va conserver les simples lignes de code pour afficher tout un tableau, ça permet de tenir à l'écart quelques casse-pieds et de faciliter les traductions (vérifié hier, c'est simple). La seule solution va consister à exiger un relèvement de cette fameuse limite tout en sachant qu'on va surement avoir des tableaux pour les classements annexes, pour les équipes participantes (on peut déjà les lister sur Wikidata depuis juin 2015, mais pas encore les afficher sur Wikipédia), et pour la liste des participants (je ne sais pas encore comment entrer tout ça de sorte à même conserver le directeur sportif, mais ça viendra) dans un futur plus ou moins proche. Cette solution est extrêmement simple puisque ça ne nécessite que de faire varier une ou deux lignes de code Ça prendra un peu de temps pour que la requête aboutisse parce que par expérience il faut toujours répéter et répéter encore. Par ailleurs, il n'y a pas de code Lua visible par le contributeur lambda, il a juste les informations à lire dans Wikidata mais ne voit jamais les 2000 lignes de code, il sait que ça marche mais pas comment (et d'ailleurs, quand je donne le programme à quelqu'un, je ne lui parle même pas de code, je lui montre juste les fonctions et la manière de remplir). Jérémy-Günther-Heinz Jähnick (talk) 12:01, 4 July 2016 (UTC) Pour t'en dire un peu plus, on rencontre un problème similaire avec teamroster, ce qui prouve bien qu'il est temps de moderniser un peu Wikipédia.

I think this on dawiki will not work till the very end.--Chris XC3000 (talk) 19:41, 5 July 2016 (UTC)

Exact. I think the first problems will appear today or tomorrow. Fortunately, stage races represent around 10 to 15 % of races. But the fact is Wikipedia must know a certain modernization, it is time. Jérémy-Günther-Heinz Jähnick (talk) 08:21, 6 July 2016 (UTC)

Another article with this problem: de:Österreich-Rundfahrt 2016. I would rather say, that we have to change the design of the table. --Molarus 14:51, 13 July 2016 (UTC)

I have fixed a small error in the code. The fr Version of this race had a problem with the prolog, because the prolog was only 70 seconds long. Therefore it showed "en01 min 10 s".

I have also changed the code in module Version 2 to show in fr the classification tables with the country names and in all the other wikis without the country names. It would look like this Module talk:Version 2 outside frWiki. There is no problem anymore with national teams. I have seen, that sometimes Tour d´Autriche 2016 is shown in 3 seconds and at another time in about 10 seconds. This new update would reduce the possibility to crash lua. And reducing the number of riders in a table helps a lot. But I don´t know if I should copy that update to WDWiki.

I have done another test, I have printed the same table 5 times (without reading the data again from WD) and the time to run was the same as for one table. Therefore classification 3 should work. --Molarus 19:38, 13 July 2016 (UTC)

Amateur team

Hi everyone, I come back to you about a topic I have already spoken about two month ago here. The thing is that I am not completely happy with the display of "Cycling race/teamroster" for "neo-professionnal" and riders that goes back to amateur level. Jérémy answered me that it was no problem to create an amateur team, so we can follow where the rider come from. Let's take the example of Adrien Petit, he is by Cofidis from 2010, in team roster it will be noted "last team: CC Nogent (2009)", which is perfect. Here it is not a problem, because the CC Nogent is a "big" team even though amateur. For women, it is very different. Most of them almost start as professionals. Amateur means really small team there. I won't insert them in wikipedia or wikidata for sure. So I got result like that :

Team roster 2016
Rider	Date of birth	Previous team
Qi An	22 June 1992
Bai Yue	13 December 1992
Qiaolin Chen	2 September 1996
Huang Dongyan	14 December 1993
Huang Li	23 December 1988
Jiang Xiujie	5 January 1989
Li Jiaqi	27 July 1995
Liang Hongyu	23 October 1990
Liu Yanan	25 February 1992
Luo Xiaoling	20 September 1988
Meng Zhaojuan	14 December 1989
Pu Yixian	23 December 1992
Sun Xue	23 November 1990
Wang Wantong	16 February 1994
Zhao Xisha	28 September 1992
Source: UCI

All P54 properties are filled, but none of the rider has ever had another team.

My proposition (because, I am not just here to criticize). We could create a fictive team "Amateur team" with official name "Amateur", in order to display "Amateur (2009)" instead of nothing. Everyone would then understand when the rider started to be a pro. We could go further and create fictive teams "suspended", "retired" and "ill". If we want in the future to manage the field present team with the help of wikipedia, it would allow displaying "retired" for instance. What do you think? Psemdel (talk) 11:45, 20 July 2016 (UTC)

Just some ideas about that topic.

At the moment we have to add as qualifier a start time and an end time or only a start time. The "Amateur team" would have a start time and an end time too. That item would therefore not indicate that the rider had been in many "Amateur teams".

Another point is that this way we would add a placeholder item into the rider item with few information to show in the team table. I would not show virtual teams "suspended", "retired" and "ill" in the team table (we have the notes for that), but they could be useful in a possible rider table (or to complete the P54 biography). Why not add something like the "official name" into p54? This way we could say in the rider item and in the table, that the rider was in those teams without creating an item for those teams. P54 wants an item as value. We could add the item "Amateur team", "Rider team" or something else as value and P1448 (official name) as third qualifier (next to start time and end time), which value would be shown in the table. (I have not thought about coding that. I´m sure that would be possible, but it would not be simple. For example, we now have code to sort that table (as an option in most wikis and as the standard in some wikis) and those new team names have to be sorted too.)

And there is the option that the column "Équipe précédente" is switched off when there is no data to show.

By the way, I have found those items: Q20653570 (équipe régionale), Q20639848 (club cycling team) and Q20652655 (équipe cycliste amateur)

--Molarus 21:41, 20 July 2016 (UTC)

Hello, you are right there are many possibilities. It was just a proposition. The goal of wikidata is to make a harmonization, so I won't start doing something for "my teams" before we have an agreement. Of course an item with the real name of the team would be better than a general "amateur team", still I am not sure that we will find the information so easily for every riders. A compromise between nice to have and pratical has to be found. Psemdel (talk) 16:33, 21 July 2016 (UTC)

Sorry, I have problems to write at Wikipedia and Wikidata for hours. I have not written about "an item with the real name of the team". My idea was about your "amateur team" item plus a qualifier where we could write in monolingual text (that is what the "official name" property uses for the value). The advantage would be that if we write P54:"amateur team"; qualifier P1448:"abc", the table would show "abc" as "Équipe précédente ", even if there is no item "abc". But, lets see what Jérémy thinks about this. --Molarus 01:28, 22 July 2016 (UTC)

Hi everybody, and sorry for the late, I work every day IRL. If we see on the long term, it is not a problem to create items for each amateur team even if it is very small structures. One after one you will create these items, and fill them when you will find informations and add sources to store interesting links. It is not a problem if during one or two years we don't have the information about previous teams, because we will spend our time to enter other informations or give functions to other Wikipedias. On a long term, we will all use Wikidata, so the time saved will be use to search more informations that take more time, or sometimes directly take contacts with teams or riders. The idea is to increase the quality of the content. Being able to list all the teams of a cyclist since he starts is a good thing, even if it can be very difficult. Jérémy-Günther-Heinz Jähnick (talk) 08:12, 22 July 2016 (UTC)

Disambiguating link

The template Cycling race/teamroster seems to contain a link pointing to the disambiguation page Ulan. This should either be unlinked or pointed to a more specific title such as Ulan Pro Cycling Team. Nick Number (talk) 16:15, 16 August 2016 (UTC)

Sorry, I don´t understand. Special:WhatLinksHere/Q2474535 does not show this. --Molarus 17:35, 16 August 2016 (UTC)

@Nick Number, Molarus: I am having the same trouble with the disambiguation page Koga. Please read the discussion here. I know extremely little about Wikidata, so would be very grateful for help from this project. Gorthian (talk) 03:19, 22 August 2016 (UTC)

You are right that this module is the reason of the problem, at least I could delete one Link to Koga disambiguation page. The problem disappeared after deleting all the team members of the cycling team Mitsubishi–Jartazi 2008 in Wikidata. The problem did not come back, after reverting the deletion. I don´t know, maybe the link was somewhere in the wikidata database. I have asked the developers at Wikidata:Contact_the_development_team#Problem about that. --Molarus 07:24, 22 August 2016 (UTC)

It seems the links to the disambiguation pages are fixed. @Nick Number, If you see more such errors, please tell me, I know now how to fix them. --Molarus 22:56, 22 August 2016 (UTC)

I'm not sure I understand what happened, but thank you for addressing it. Nick Number (talk) 05:49, 24 August 2016 (UTC)

Now I´m sure (I have done a test) that this mess was created by the lua function mw.title.new I´m using this function to detect false blue Wikilinks. A rider or a team item has no local wikipedia article therefore a red wikilink should be shown in the table, but a blue one is seen, because there is a different wikipedia article with the same name, for example a disambiguation article. If I don´t find a different solution, the red links have to go, because there are lots of false Whatlinkshere. Cleaning that mess will be the next big problem. --Molarus 12:07, 25 August 2016 (UTC)

Referenzfehler

At de:Veranclassic-AGO there is an error message, as someone told me. It seems references is still not where it should be. I´m looking into that problem. --Molarus 21:24, 22 August 2016 (UTC)

Should be fixed. And I have changed the code. Now, if there are more then one note, they all start at the same column as the first note, see in this example. It seems, only the english wikipedia shows the same table (with this error), why I will fix the module in enWiki too. --Molarus 22:30, 22 August 2016 (UTC)

listofteams

Hi Molarus. The time passes and thanks to you the module is able to do more and more things. Today I create the article about 2016 Grote Prijs Stad Zottegem (Q20827587), a race in Belgium I illustrate in 2014 and 2015 but not this year (due to a car...). Since the 1st of june 2015, we are able to list teams that participate to a race thanks to participating team (P1923). I am interested if you can prepare little to little a function listofteams that will display the participating teams following the example of DE Wiki on de:Vuelta a España 2016. For this, we already have translations in the module. Jérémy-Günther-Heinz Jähnick (talk) 10:36, 23 August 2016 (UTC)

I find the German version design too bulky, no need for the table headers. English article version is better. Flags could be added, though. If we we want to use this module in multiple Wikipedias, the design should not be too custom. --Papuass (talk) 12:09, 23 August 2016 (UTC)

Ok for the EN version, with flags. Jérémy-Günther-Heinz Jähnick (talk) 13:13, 23 August 2016 (UTC)

Could somebody give me a link to the en version? But I´m afraid the problem with the "Disambiguating link" is not done, despite the two errors are cleaned. I have to fix the code that creates that error first and then I will look if I find more of those errors. --Molarus 23:32, 23 August 2016 (UTC)

en version. --Papuass (talk) 08:32, 24 August 2016 (UTC)

With my last update on FR Wiki, I lost the competition on the infobox, see fr:Grand Prix de la ville de Zottegem 2016. Jérémy-Günther-Heinz Jähnick (talk) 13:09, 24 August 2016 (UTC)

I had changed the module without much testing the new code (I didn´t see that disappearing), thanks for doing that for me. -)) I have fixed WD and frWiki version. That was the fix that I hope will correct the Whatlinkshere error. I will wait some more time before I move that fix to all our local modules, I don´t want to do that twice. The problem with that fix is, that it is in the function WDLink, that is used in all our tables and therefore an error could happen in all our tables. --Molarus 03:23, 25 August 2016 (UTC)

I would say, if there are no local saison article, print the team article. Another point is, there should be more than one column, maybe depending on the available space (it would be nice the table would do that on its own), and the headings are the values of the p31 in the team items (UCI WorldTeam, ...), maybe depending on the time of the race. What do you think?. Probably starting with that next week. --Molarus 02:33, 25 August 2016 (UTC)

I have a first version, what do you think? (The data at the top is printed only during development) The headers are real section headers, type H3. Another point: The headers are from the labels not from the module. This way the code works with every P31 value that is inserted into Wikidata. For example, in 10 years, there is no "WorldTeam" anymore, there is something new and just type into WD the new item as value for P31 and it is printed with all the teams below the header. The same is possible with some regional team category, we don´t know and therefore I can´t write into the module. This code should work with such team categories too. At least I hope the code will do that. Maybe I could make a combination of label headers and module headers and maybe I should code, that the first letter for a label header is written in large always? At the moment, the time of the race is not taken from WD, I just say the date is 2016. --Molarus 07:45, 31 August 2016 (UTC)

I will read this tomorrow (again a long day on the terrain...). Jérémy-Günther-Heinz Jähnick (talk) 18:34, 31 August 2016 (UTC)

Ok, so I take the time this morning to read the code and to understang it. I make tries with other races. For the name of the instance of (P31), it is better to take the module (and even to prepare one or two fields for the future if necessary) because we will often use the plural form. Fot the list itself, I would prefer if we have four teams by line, and an alignment. We will have more space between teams. I guess it will be easy to take the official name of teams.

1) I have not thought about the singular - plural problem. OK, module data will be used and the labels are the fall back. 2) About the table: You want three tables: One for the "WorldTeam", ..., right? It is interesting, that the wikicode in en:WP adapts to the size of the screen. With a small screen there is only one row and the larger the screen, the more rows are used. The problem is, I have no experience with coding (and understanding) templates. 3) "Lotto-Soudal 2016" should be shown as "Lotto-Soudal", but it should link to "Lotto-Soudal 2016" if available. I have done this for the guest riders, it is no problem. 4) Could you have a look at the "guest rider" section, where I have written a proposal. --Molarus 11:28, 1 September 2016 (UTC)

2) I have found a solution, incredible! Finetuning later. At the moment I have given each column the width of 20 em. It would be nice to know the smallest possible column size without happening a line break. Maybe this is possible to calculate by counting the number of characters of a team name multiplied by a factor? --Molarus 14:09, 1 September 2016 (UTC)

For the 2), it will not be tables, just a display similar to en:2016 Vuelta a España with the flags in more. I don't know how it works, but the display is good. 4) for the guest rider section, I think you speak of your idea weeks ago of a function stage&generalclassification that will be lighter than the main functions. Jérémy-Günther-Heinz Jähnick (talk) 16:04, 1 September 2016 (UTC)

Ah, it is very good ! Is it possible to have just before the type of teams the number of these teams ? I see yesterday you display it an another place. Jérémy-Günther-Heinz Jähnick (talk) 17:27, 2 September 2016 (UTC)

I thought about actually writing "10 teams", but we don´t have a translation for "teams" only for "team". I have seen, that we do not have items for all translations, at least I have not found the item for "Équipe régionale et de club". I have found "UCI Women’s Team" for the last translation "Équipe féminine", I´m not sure if that is right. Are there more women team categories? You can see the items to the translations in Module:Version 2 at line 100. If there is an item as value for P31, that is not in this list, I will take as fallback the label. I have tested that with commenting out parts of the list. And the first character is written in big letters (that is done with "text-transform: capitalize"). I think the next step is to go back and look another time into the code that I have written first. For example, I have to test what will happen, if there is no P31 in the team item. And I had inserted an ugly fix, but I don´t understand why I had to do that. I hope I can correct the code and delete that fix again, tomorrow. --Molarus 18:06, 2 September 2016 (UTC)

It is now very very good. For womens, we have équipes féminines or équipes de club (club teams, also for men). I think we will can start tests on real articles. It lacks just a point : because it is content inserted from Wikidata, it is not possible to include directly in the article, we need to have a little frame and on the right a little logo Wikidata that point to the item at line #P1923 (participating team (P1923)). It is just a detail but it will be very important. Jérémy-Günther-Heinz Jähnick (talk) 11:38, 3 September 2016 (UTC)

That´s my design proposal: The yellow line (2 px) at the bottom is as long as one column above. Maybe more space bellow, it is 0.5 em at the moment? --Molarus 14:53, 3 September 2016 (UTC)

No, it must be a real frame, like a table. Jérémy-Günther-Heinz Jähnick (talk) 17:23, 3 September 2016 (UTC) For the explanations, it is because content that come from Wikidata must be see as content from Wikidata by people, that include parts included like text or chapters. I will write today the documentation for this function and for TTT. I am interested if you can include the content of listofteams in Cycling race, I will take this time in the beginning of this week to give the functions at others Wikipedias during two days and a half, and all the functions to IT Wiki. Jérémy-Günther-Heinz Jähnick (talk) 08:29, 5 September 2016 (UTC)

Now, with gray border too. I understand that people should know that, but I don´t think that a border around the text will help with that. Maybe another design will be better? I have added the yellow line because I can´t just print the wikidata flag somewhere (there is no header) and I can´t print the flag nearby "WorldTeam", because the flag is not about "WorldTeam". I have thought about a yellow line from the right to the left border, but this would be to eyecatching. I´m open to better proposals. About copying the code to this module. I have not tested the code at weekend and I don´t want to fix the code at ~20 Wikis. I think, it would be better to deploy the code at one wiki, maybe frWiki, and after one week testing the code and the design, the code could go to all the other wikis. And maybe someone at frWiki has a better idea for the design too. By the way, I was active at plWiki at weekend, see pl:Dyskusja_modułu:Cycling_race. And there is an error at one table (see: pl:Team Sky). At least I have tested the Wikidata data of that Team 2015 with the latest code and got no error, maybe the reason is that they do not have the code for the notes. I could try to fix the old code at plWiki, if they want to keep that version. By the way, references are shown only at enWiki, frWiki and deWiki. I have not coded that for the other wikis, but I could. The code for references seems to be OK now. --Molarus 12:03, 5 September 2016 (UTC)

I´m moving listofteams to this module. I have tested it at deWiki and frWiki at my user page a bit. I had to change in function WPLink the code, but I hope I have not created no new errors. I was right, that I had to change a lot in the function listofteams, but I hope it works now. Please, lets see first if the new code is all right and do not create errors in other articles. --Molarus 07:10, 6 September 2016 (UTC)

Thank you Molarus. So I decide to annonce it on FR Wiki and explain that just tests will be done to detect the bugs at particular situations. The functions is on fr:Modèle:Cycling race/listofteams. One try have been made by me on fr:Grand Prix de Fourmies 2016. All is good, except one detail : is it possible the table go just below the text instead below the infobox ? For stage race we don't have this problem, but we have it for single day races where in more we generally have few text. Relscar, a new user, made a test on fr:Tour de Grande-Bretagne 2016. Is it possible to have a "hierarchy" in the order of appearance of teams ? For example WorldTeams, Pro-Continental, Continental, national... On another point, and I think you have the code, for a national team is it possible to use the name of the country and for a national U23 team the name of the country followed by "espoirs" (or others following the language, we already have a base for this). I am interested if we can delete the yellow line. For the rest, all is good. Jérémy-Günther-Heinz Jähnick (talk) 09:15, 6 September 2016 (UTC)

1) I guess the border is the reason why the function did not adapt to the size anymore. I had tested that with the infobox as there was no border. I gave the gray border the size 95% of the page and that is what the border is doing, I guess. Maybe it will work without a size, I will see. About the yellow line: I can´t just place the icon somewhere. The yellow line separates the table into data and something else, similar to the infobox. Design has to solve a problem and the unanswered problem is where to place the WDflag. I do accept that the yellow line is no good solution, but no yellow line is worse. 2) I think ordering should be possible 3) Should be possible. --Molarus 12:29, 6 September 2016 (UTC)

1) yes it is the size (Now it is in frWiki without a size of the border, but with one box next to another box. When you look at fr:Modèle:Cycling race/listofteams, the size is now the full page, which looks really bad. I remember that I had tried a smaller size for example 20% and the width of the table was only 20% of the page. I remember that I had tried a yellow border too and in the end the yellow line was my choice. Maybe you can find a solution for that and the yellow line problem together with the editors from frWiki? I will not look into that problem again for the next days, instead I will look into the other two problems.

I have found another problem, see fr:Utilisateur:Molarus#list_of_teams. There are too many saison items with no "official name" property. We have not seen this, because so far we didn´t show the saison articles but the team article. There are two options: Adding more "official name" properties or adding code that the module looks into the main team item to get the data if there is no "official name" in the saison item. --Molarus 14:37, 6 September 2016 (UTC)

Finally no problems with the yellow line (I am sometimes pessimist). And for the integration in an article, it is now good, see fr:Grand Prix de Fourmies 2016.

The solution is just adding more official names, but it is not a problem, every day we add more and more datas, for example yesterday I make the article fr:Équipe cycliste IJsboerke, with eight rosters. In your example, it was datas from 2015. In this period, we were just at the beginning of the use of Wikidata. At this period there was again questions about the way to fill Wikidata. It is interesting that we can detect these problems, because we are able to correct them fastily. Jérémy-Günther-Heinz Jähnick (talk) 09:41, 7 September 2016 (UTC)

see Module talk:Version 2: I´m using "max-width" now, this way the table + border adapts to a page with an infobox and it is not 100% of the width of a page. I have already the code for showing, for example, 'France U23'. By the way, the heading "National cycling team U23" is created from the fall back code, since we do not have this heading at function headoftableIII. Next step is the order of the team types. I think, I will add the order information as third parameter to the variable list (where I´m writing the numbers for singular and plural headings). For example, if we would add into function headoftableIII the translations for "National cycling team U23", we had to add the singular, plural number and the order into this variable. --Molarus 10:49, 7 September 2016 (UTC)

For national teams U23, I am not opposed to put them with national teams, because we never have national teams elite with national teams U23, and with the name, we already see that it is France U23.

In the same way, I modify the module to recognize club cycling team (Q20639848). We will can group this section with regional team (Q20653570), to have équipes régionales et de club. Note that it is very rare we have regional teams.

On another point, we have a good case thanks to our new user Relscar that create fr:Tour de Bohême de l'Est 2015. The race took place just one year ago in september. Seven Rivers 2015 (Q20742529) was a club team at the beginning of the year but becomes a continental team the 28th may, but here is considered as an Équipe régionale et de club because it is the first value for the statement for the type of the team. (for a future case, I will search for a team that change the country of its licence during a season.) Jérémy-Günther-Heinz Jähnick (talk) 17:21, 7 September 2016 (UTC)

The code is sorting as you can see on this page, but I´m not 100% sure the sorting is done. More testing is needed. But first, I will add the code for more than one P31 (tomorrow). I guess this is a similar code as for finding the right "official name", therefor "copy and paste" will be a big help. --Molarus 16:30, 8 September 2016 (UTC)

Yes, I was discussing this morning with Anthony59999, and he give me the example of Tinkoff-Saxo 2014 (Q15409910) that was danish during one month this 2014 season and Russian the rest of the time, I will write teams for Grand Prix de Wallonie 2014 (Q18071193). For names that change during a season, I have the case on 2016 Tour de France (Q18574623) with Cannondale-Drapac 2016 (Q21769874) and Orica-BikeExchange 2016 (Q21771170). I think they are the last points to see. Jérémy-Günther-Heinz Jähnick (talk) 08:24, 9 September 2016 (UTC)

I had forgotten that function timeStartEnd is used for that, therefore no problem to code that. At the moment we use only the start time to decide which P31 to use. Being 100% correct, I should use start time and end time for a stage race, but I do not. I have tested the code with setting the date to 27-5-2015 and 28-5-2015 in the code and the table is changing the right way. The flag function is using the start time of the race already, therefore the code should be right, but I will test the code with this example. --Molarus 20:45, 9 September 2016 (UTC)

I have tested the code at deWiki and frWiki, the new code is at WDWiki and frWiki. Maybe you want a different order of the team types (third parameter), just change it. --Molarus 17:07, 10 September 2016 (UTC)

Guest rider

Stage classification Rider Team Time 1re Élise Delzenne Lotto Soudal Ladies 17' 06" 2e Coralie Demay Poitou-Charentes.Futuroscope.86 + 19" 3e Edwige Pitel SC Michela Fanini + 21" 4e Claudia Lichtenberg Lotto Soudal Ladies + 33" 5e Sofie De Vuyst Lotto Soudal Ladies + 34" 6e Eugénie Duval Poitou-Charentes.Futuroscope.86 + 35" 7e Yūmi Kajihara Japan + 38" 8e Daiva Tušlaitė Inpa-Bianchi + 42" 9e Alison Jackson BePink + 50" 10e Eri Yonamine Poitou-Charentes.Futuroscope.86 + 51"

Hi, I just have a very small issue concerning Trophée d'Or féminin 2016. In the first stage Alison Jackson is ninth. She rides normally for Twenty16-Bikerider. I put in P54 here that she rides for this race for Bepink. I don't know why Twenty16-Bikerider is displayed. Any idea? Psemdel (talk) 18:58, 23 August 2016 (UTC)

I have looked into the code. It seems that the code is looking into the team item for a P31 with the values Q20738667 (national cycling team U23) or Q23726798 (national cycling team) and only if this information is available the code uses the additional team data in the stage classification section. That means, the code is testing for a national team and a guest team is ignored.

I could write code so that adding a guest team is possible. I´m no cycling expert, should I just say, that any team in the stage classification section that is no national team is a guest team and overwrites the team data in the rider items? --Molarus 23:26, 23 August 2016 (UTC)

I suppose it could create no mistake to do so (why would someone introduce a false p54?). It is true that it is a problem only for women riders as men are never making guest team. Psemdel (talk) 20:35, 24 August 2016 (UTC)

I have changed the code in WD and frWiki. Please have a look and tell me if something is wrong now, at least I have nothing seen at "Trophée d'Or féminin 2016".

I have seen that you have inserted "Bepink 2016" not "Bepink". So far the code doesn´t switch from a saison article to a team article, if there is no local saison article. Maybe this would be a good new feature.

I have seen that the function I have changed is used also from the infobox to show riders in a national team (see fr:Triptyque des Monts et Châteaux 2016). Inserting a guest rider should be able there too.

About guest teams for males, maybe Jeremy has an answer for that?

--Molarus 04:29, 25 August 2016 (UTC)

Hi Molarus. Since today I have a problem for the 10th at the general classification of the third stage of the fr:Tour du Poitou-Charentes 2016. See Damien Touzé (Q22944392) and Q26696104. When we add an info on member of sports team (P54), the program must display the official name and make the link with the article if it exists. Jérémy-Günther-Heinz Jähnick (talk) 16:55, 25 August 2016 (UTC)

Now the 'winner_team' part of function WPlink is used. The code is difficult to understand, but if there is no Wikipedia article of the saison, the team article is printed, if available. It seems the code is already doing what I have proposed above. --Molarus 09:27, 26 August 2016 (UTC)

Hi Molarus. Another bug has been detected today on fr:Tour de l'Avenir 2016 for the french U23 national team that have an article. I can't explain the error, but I already see this type on configuration in the past. Jérémy-Günther-Heinz Jähnick (talk) 18:03, 27 August 2016 (UTC)

I think it is fixed.

I have an idea for the articles with lots of classification tables. We could make it possible to switch the tables in the article into a table that do not need the same amount of lua time and expensive lua functions as the normal classification tables. Maybe a switch called "less lua" and we could tell the table to show only the first x winners. This way we could add maybe the first 10 winners into Wikidata, but show only the first 5 winners. I have done most of the code for the first part, therefore this would be a quick fix, less than a week to work. --Molarus 04:12, 28 August 2016 (UTC)

The function stage&generalclassification we speaks weeks ago ? Jérémy-Günther-Heinz Jähnick (talk) 15:57, 1 September 2016 (UTC)

That new idea is more conventional. You may have seen that both classification tables on this page do not show the country name. At the moment only WDwiki does this. I would add into the module that editors could switch on this per table in the article too. The second proposal would be also per table in the article, therefore we could show for example 5 rows in the stage tables, 5 rows in the general tables and in the last general table 10 rows. Another advantage is that we could show for the same race in one language article one 10 row general classification table and in another language article 3 rows in 10 classification tables, all with the same data (10 rows) coming from WDwiki. And it is possible to delete that configuration in 2 years if we have faster hardware / software (maybe by bot). --Molarus 10:21, 2 September 2016 (UTC)

Ah, for the point I prefer editors see that a limitation of expensions functions calls is now making problems. If they don't see there is a problem, they will do nothing where it is juste one or two points to modify in the code. It is human nature, people only see a problem when it is here, and they don't see it when it risks to arrive. Jérémy-Günther-Heinz Jähnick (talk) 08:19, 5 September 2016 (UTC)

Nice!

Someone pointed me to de:Kategorie:Wikipedia:Seite mit Skriptfehlern. This is a Category that lists all the article with Lua errors and I have already found some cycling articles. Each Wikipedia has this category. I have found for example this fr:Catégorie:Page avec des erreurs de script. These Categories are a great help. --Molarus 08:12, 26 August 2016 (UTC)

Already two errors fixed. This is a really fast way to see what problems exist. --Molarus 08:54, 26 August 2016 (UTC)

Interesting, I think I will put a note on the front page of the module. This way users will have the information. Jérémy-Günther-Heinz Jähnick (talk) 18:00, 27 August 2016 (UTC)

Broken on en.wp

I mentioned this at en:User talk:Molarus but not sure if that would be noticed so reposting here. The recent change has broken a number of articles:

• en:List of Astana City rosters
• en:List of Team Joker rosters
• en:Lokosphinx
• en:Team Bliz–Merida
• en:Team Joker Byggtorget
• en:Team Tre Berg–Bianchi

Only a small fraction of the pages the template is used on so possibly a data problem for just those pages.--JohnBlackburne (talk) 17:28, 4 September 2016 (UTC)

That is already fixed. I had copied only half of the fix to en:WP, that was all. Sorry. --Molarus 20:21, 4 September 2016 (UTC)

error, red links had been gone and more

• I have rewritten function listofwinners and while testing the code, I have seen that the red wikilinks had been gone at all tables. The code at WDwiki and at all the other wikis, where necessary, are fixed. But, I could not edit esWiki. Maybe you can do that?

• I have tested the rewritten function listofwinners at frWiki and I can´t see any error. The reason for doing this, is that this is a very old function. Is is so old, that the function is not using function WPlink (transforms Qnumbers into Wikilinks). I have made lots of optimizations and therefore the function is now a lot smaller and I hope faster too. Before I will copy the function into WDwiki, do you have any wishes to improve that table? I have, for example, seen at fr:Philadelphia_Cycling_Classic#.C3.89preuve_masculine that this table has lots of additional text within the table. That is like our table listofstages, where it is possible to modify the table in the article. We could have something similar too. Or the table at Module talk:Version 2 has lots of empty lines, we could show only those years with content. Another option: At the moment, we show the oldest year first. I´m not sure if that is the right order, I would prefer to show the latest year first.--Molarus 05:55, 14 September 2016 (UTC)

Hi Molarus. I update ES Wiki, I don't understand why you cannot modify their copy, maybe there is a number minimum of edits, I don't know.

For listofwinners, I am not oppose at a fonction similar than we have for listofstages where we can add a line, as example if the race change its name. In cycling, when I go on a race, the palmarès is from the first edition to the last edition. Another idea, because it is now possible, is maybe to associate the team to cyclists. We have seen that for infobox it was very interesting and appreciated. :About listofteams, I have two points that rest to solve : the case of a team that change its name during for the season, and associate équipe cycliste nationale espoirs with équipe cycliste nationale. Our new user continue to write articles, and it is good. On another point, I surprised an admin vandalising the module for the infobox of cyclists. If he continues, I think I will appeal against his administrator status. This is not the first time that this person makes problems. Jérémy-Günther-Heinz Jähnick (talk) 17:29, 14 September 2016 (UTC)

Have a look at Module talk:Version 2. The command in the WP article would be "|above row x : aaa bbb ccc". What do you think? I have seen in the linked example, that a new row could be at the first line, therefore "after row" as in the other table would be false. Do you think "above row" is correct english? At least I have found in the internet sentences like "insert a row above row" I thought first about "before row", but it seems that is false.

About teams in the table: That would be a lot of additional content. For example, "Grand Prix de Denain" exists for over 50 years, that means 50 rows. Adding teams for 50 * 3 riders, maybe lua would crash because of too many expensive lua calls.

About listofteams: "associate équipe cycliste nationale espoirs with équipe cycliste nationale". Could you explain that a bit more, because I don´t understand? --Molarus 19:09, 15 September 2016 (UTC)

Hi Molarus.

First point, I make today a test on fr:Quatre jours de Dunkerque 1980. All is good except a little bug with listofstages where the stage 5a is not at the good place, and I am not able to explain it (a different view can be good).

Second point, I think it is good but I can't be sure, my english is very very basic. The main point is eveybody should understand, we have a very few people in the project that have english for native language.

Third point, a page crash when we have classification for 100 cyclists, infobox and list of stages. On an article about history of race, we have generally only this table plus a little local infobox. I think we will not encounter problems. The fact is also it will be very very long between seing big palmares, because it is long to do. Jérémy-Günther-Heinz Jähnick (talk) 13:11, 16 September 2016 (UTC)

Fourth point, we have for the moment ["Q23726798"] = "12:13:6", -- national cycling team in the code. Because we never have on a race Elite and U23 teams, we can have a line with under-23 national cycling team (Q20738667) ["Q23726798","Q20738667"] = "12:13:6", -- national cycling team (for example). Idem, we can associate club cycling team (Q20639848) and regional team (Q20653570), as we do on FR Wiki. Jérémy-Günther-Heinz Jähnick (talk) 13:11, 16 September 2016 (UTC)

1,2) The problem was the sorting code of that table. Problem fixed. I have updated listofwinners too. WDWiki, frWiki and deWiki have both tables updated. 3) Maybe at another day. 4) I will think about that later, maybe on Monday. Now that listofwinners is updated, I will look again into the WhatLinksHere-problem. --Molarus 18:08, 16 September 2016 (UTC)

You have all the time. We continue tests with teams (our new user is a very big worker). For another test, I translate an article in catalan. On another side, with Anthony59999 (it makes two years and a half we work together), we are compilating datas about attributed points following the type of the race and the year. We already know these two informations for each race, so the idea is for the future to create a new function that will for the big part of cases decide of the good table to display. After one example, I am decided for a time to create all the other tables. And finally, I am maybe in race tomorrow, I am note again sure (an undetermined vehicle collided me one month ago). Jérémy-Günther-Heinz Jähnick (talk) 17:57, 17 September 2016 (UTC)

I have seen at fr:Utilisateur:Molarus that "équipe cycliste nationale espoirs" is a red link now. I guess the section headers should not be a Wikilink. I have a question about frWiki. I have started with looking into false wikilinks at frWiki. So far, I have written "rider name (cyclisme)", which I have seen in the articles. But many disambiguation pages in frWiki write "rider name (cycliste)". I´m not sure if I should continue with "cyclisme". I have seen frWiki has lots of false Wikilinks, therefore it is a problem if I ´m adding the false text to the article names. You can look yourself into the data, the articles I´m looking into are written at my user page in frWiki. It is really difficult to delete those wikilinks from the WhatLinksHere-list. There is one article at deWiki, I can´t get the WhatLinksHere-list cleaned. I will do everything again, maybe this time. --Molarus 00:07, 19 September 2016 (UTC) I have looked once again into the module and this time it was obvious to me, that I have made a logical error. Fixing that in the code, the WhatLinksHere-list was cleared with just purging (adding "?action=purge") the article. I hope, it stays that way. --Molarus 00:34, 19 September 2016 (UTC) I have looked into most of the articles at deWiki that uses our module and I have learned that riders written in black are the ones that have an article with the same name, but a different topic. And there are now about 30 such rider articles, not 5. It seems the python code is not necessary for finding the "black" riders, and maybe that python code didn´t work well. I have added the rider names into the lua module (see dif) and the false WhatLinksHere are gone on its own. That is what I had hoped from the start. It is negative that there are far more rider articles with a problem. I don´t know if I still should correct the false wikilinks at frWiki, since it is now easy to detect "our" false Wikilinks -> they are the "black" rider names. This lua code is at the moment only at deWiki. I will see tomorrow later if the situation is still this way and maybe I will find a faster way to code that solution. At least at that page (at the bottom) they say, the way I have written the code is the way it should be done. PS: I hope you were at the race. --Molarus 02:00, 19 September 2016 (UTC)

No, finally I rest at home. I still hurt, it is difficult to stand for several hours or walk a lot, but the worst is that I still tired quickly, I think/hope it will get better in a few weeks or months. Fortunately I recovered the pace bike (and it is the most important for me). I go on FR Wiki, in this case, we always use the word cyclisme, I remember few times ago an user rename in cycliste but he was reverted, it is not impossible that few cases are again here but it is a mistake that should be corrected. Équipe nationale espoirs should be associate with équipe nationale, I explain few days ago that it is impossible to have Elites AND U23 at a cycling race. Jérémy-Günther-Heinz Jähnick (talk) 08:45, 19 September 2016 (UTC)

Maybe I have the code for function listofteams. At Module talk:Version 2 you can see at the first table, that "France espoirs" has the same heading as would have "France elite" -> "Équipe nationale". I have done that by just adding the Qnumber for a U21 team into the list with the same "12:13:6" parameter as a national team. The second table is the example with saison articles with more than one "official name". "Cannondale-Drapac" and "Orica-BikeExchange" are such cases. I have also changed that if there is no local wikipedia article (true for WDwiki) not "team name 2016" but "team name" will be shown. I have tested the new code for deWiki and frWiki. What I have not tested so far, what will the new function WPlink print in all the other tables? Maybe somewhere else a problem could happen. --Molarus 17:39, 21 September 2016 (UTC)

The new code is at WDwiki, deWiki and frWiki. It is an important update. For example de:Vorlage:Cycling race/teamtimetrialclassification didn´t show the teams as blue links, now it does again. I guess the reason was that the saison article was inserted into the item and if there is no such local article a black link was seen. I think I have coded that table for using team articles, not saison articles. I have seen the same problem in many wikis, they need updates too. The new code switches in this case to the team article (if there is a property, I guess "is part of", in the saison article.). I have tested the new code with all our templates at deWiki and frWiki to see if all our tables work well with that updated. It seems it is all right. But I have seen two other problems. 1) Look at the infobox at fr:Modèle:Cycling race/infobox. Someone added the info "Grand Prix de Fourmies 2015" is part of "Coupe de France de cyclisme sur route 2015" into WDwiki and that is shown in the infobox now. I have to find a way to fix that. 2) Look at fr:Modèle:Cycling race/listofstages: Now a stage is a blue link even there is no stage article in the local wikipedia. I have to fix that too. I don´t think both problems are connected to this update, therefore the update is OK, as long as we don´t see a new problem. I will look around today and tomorrow if everything is all right and I will start with fixing the two problems. Maybe after fixing both problems we could give the new code to all wikis. Maybe on Monday? --Molarus 18:32, 22 September 2016 (UTC)

Some script errors were happening, which I have fixed. It was an old error in the code. For example "fr:Tour du Portugal 2016" showed the false "official name" of the "Meilleure équipe" in the infobox and now that error created a script error. It seems, there are no script errors any more. Next step is to see if the tables will show what they should show. Updating all the tables will last maybe one or two houres. After that I will look into some of them. --Molarus 19:08, 22 September 2016 (UTC)

Very good work ! It solves lasts points. On FR Wiki, Toïlev, specialized on hispanic races/teams/cyclist explains me a problem, and discover by this way a case we have not predicted. Just for the fr:Tour de Colombie 2016, Mauricio Ortega, the winner, don't run for his team RTS-Santic Racing but for another team that is local : Supergiros-Gane-Redetrans. So I create items and use member of sports team (P54) to add this information. If it works for generalclassification (and we know it because of the trainees), it don't work for the infobox and I can't explain this because it works for national teams, see fr:Halle-Ingooigem 2016. I think we have not predicted a race can be win for a cyclist who run for another team (excluding national teams) or is trainee in another team. Jérémy-Günther-Heinz Jähnick (talk) 07:53, 23 September 2016 (UTC)

Next to the problem you´ve described and the "Coupe de France de cyclisme sur route 2015"-problem, I remember that there is also a problem with adding content in the article for this table. There is the possibility to overwrite WDwiki content or adding content to the WDWiki content. The last case was for the winner section of the infobox. We should have overwriting for all parts of the infobox. PS: Jérémy, could you add the row into the table for fr:"Route de France féminine" as written in section Module_talk:Cycling_race#Diverse_remarks. Then, I can move that section into the archive. --Molarus 14:59, 23 September 2016 (UTC)

Sorry for the late, I do more bike these lasts days ans spend less time on Internet. Even if it is possible to add content to the body of the article, for this specific case I would prefer if we can take in consideration the datas we have entered on Wikidata. Jérémy-Günther-Heinz Jähnick (talk) 07:53, 28 September 2016 (UTC)

1)The update for the infobox is at WDwiki and frWiki. I have tested the code at frWiki, deWiki and mkWiki. By the way, mkWiki has an old module. If you look at fr:Modèle:Cycling race/infobox you will see at the infobox "Coupe de France de cyclisme sur route" This alias text is the label from Q1137352. In french the label is far more longer then in other wikis. For example deWiki writes "Coupe de France". I don´t know if it is possible to shorten the french label. Could you look into this? Wikis who have no translations will see the english translation. 2) P54 for "Tour de Colombie 2016" in the race item works now. Someone should add the P54 for the "Meilleur grimpeur" into the item too. --Molarus 01:29, 29 September 2016 (UTC)

The "false" Wikilinks

The problem with the "false" Wikilinks is done. There is the new function black_list() where rider names should be inserted that create false WhatLinksHere in the local Wikipedias. I have done that for enWiki, frWiki and deWiki. How do you detect "false" Wikilinks? Per WhatLinksHere, but the easiest way is this: They are the "black" rider names in our tables, that means, they are written as plain text. When someone creates such a rider article, this "black" name turns into a "blue" wikilink. From time to time, I will check if I can delete some names in function black_list. I have written a python script that can find all "false" wikilinks, not only the ones our module creates. It is only a few ours of work. By the way, I have corrected maybe 95% of all "false" rider wikilinks at enWiki, frWiki and deWiki too. I´m not sure if there is another way to do that without spending a lot more time. Maybe ones a year that should be done again. --Molarus 07:10, 28 September 2016 (UTC)

It should be possible to do it (find such links) with SQL, but I'm not sure. If somebody gan give me some examples (wiki and article title) of current "false" links (and not correcting them), I could have a look. --Edgars2007 (talk) 10:58, 28 September 2016 (UTC)

There are some at esWiki: es:Joaquim Gomes es:Dylan Page es:Diego Ochoa es:André Mollet es:Miguel Chacón. The last one is an example for two cyclists with the same name. I´m not sure if there is actually a false Wikilinks in those cases, but for this rider it is true. One rider was active at the 50s, but there is also a link from "Vuelta a Aragua 2009", which is probably a link for the second rider. --Molarus 22:40, 28 September 2016 (UTC)

Addition to infobox

Hi Molarus. Toïlev is an user from FR Wiki that is specialized in hispanic races/teams/cyclists. He ask me if it is possible to include two lines for the winners of a race :

• Metas volantes or étapes volantes (the spanish name is used in English and sometimes in French) with the item winner of the intermediate sprint classification (Q27067359).
• Regularidad / régularité / regularity with the item Q27067170.

The words metas volantes are used for races in South America and Spain. If my memory is good, I have see regularity for ancient races. Toïlev Is already able to enter these datas on Wikidata. I put these two items in the kit to translate and can transmit it to contacts, idem for the translations needed. Jérémy-Günther-Heinz Jähnick (talk) 09:02, 2 October 2016 (UTC)

l10nDef["//fr.wikipedia.org"] = {"Généralités", "Course", "Compétition", "Compétitions", "Étapes", "Date", "Dates", "Distance", "Pays", "Pays",
	"Lieu de départ", "Lieu d'arrivée", "Équipes", "Partants", "Arrivants", "Vitesse moyenne", "Coût", "Résultats", "Vainqueur", "Deuxième", "Troisième",
	"Classement par points", "Meilleur grimpeur", "Meilleur sprinteur", "Meilleur jeune", "Super-combatif", "Meilleur au combiné", "Meilleure équipe", "Image", 
	"Légende", "Carte", "Special 1", "Special 2", "Documentation", "Étapes volantes", "Régularité"}

	local t = {is_a="", class="", stage="", starttime="", endtime="", time="", date="", dates="", length="", length_unit="", 
	startplace="", endplace="", nr_teams="", nr_participants_start="", nr_participants_end="", speed="", speed_unit="", cost="", cost_unit="", 
	first="", first_team="", second="", second_team="", third="", third_team="", winner_point="", winner_point_team="", winner_mountain="", winner_mountain_team="", 
	winner_sprint="", winner_sprint_team="", winner_young="", winner_young_team="", winner_fighting="", winner_metas_volantes="", winner_metas_volantes_team="", winner_regularity="", winner_regularity_team="", winner_fighting_team="", winner_combination="", 
	winner_combination_team="", winner_team="", previous="", next=""}
	local ref = {stage="", starttime="", endtime="", time="", date="", dates="", length="", nr_participants_start="", nr_participants_end="", 
	speed="", speed_unit="", cost="", first="", second="", third="", winner_point="", winner_mountain="", winner_sprint="", winner_young="", 
	winner_fighting="", winner_combination="", winner_metas_volantes="", winner_regularity="", winner_team=""}

			if qual == 27067359 and t.winner_metas_volantes=="" then t.winner_metas_volantes=note..id t.winner_metas_volantes_team=id_team ref.winner_metas_volantes=references(entity,"P1346",k) results=true end
			if qual == 27067170 and t.winner_regularity=="" then t.winner_regularity=note..id t.winner_regularity_team=id_team ref.winner_regularity=references(entity,"P1346",k) results=true end

	if t.winner_metas_volantes ~= "" then tab = tab.."<tr><td>'''"..infobox_translate(35).."'''</td><td>" .. t.winner_metas_volantes .. "</td></tr>" end
	if t.winner_regularity ~= "" then tab = tab.."<tr><td>'''"..infobox_translate(36).."'''</td><td>" .. t.winner_regularity .. "</td></tr>" end

I am not sure but I suppose we need to modify or add these lines.

Yes, you are right, it is this lines.

I have googled the term "metas volantes" and found this: "meta volante (en ciclismo) bonus sprint". I have seen "bonus sprints" at the last Tour de France. At es:Clásico RCN 2016 (es:Usuario:Douglasfugazi) "Metas Volantes" is shown in the infobox (with its own jersey). I have searched at esWiki for that term and found for example es:Vuelta_a_Colombia_2016#Clasificaci.C3.B3n_de_las_metas_volantes. There is a french article of that race, written from user Toïlev, which has a "Classement des étapes volantes" too.

es:Vuelta_a_Colombia_1995#Clasificaci.C3.B3n_de_la_regularidad. And shown in the infobox too. es:Regularidad

The item Q21061146 uses your two items.

It seems esWiki shows this information in the infobox, therefore we could add that info into the infobox too. (You have to add that info to the documentation).

About the translation: I don´t know what the translations will be. Maybe we can write the spanish word as standard and translate that if we know the translation.

I will start with that on Monday or Tuesday. It will be done maybe on Wednesday. --Molarus 18:10, 2 October 2016 (UTC)

Ah yes, I forget the documentation.

During this week, I will prepare the new function stageinfobox. It will not be very difficult because a part of the function were developped for infobox. Jérémy-Günther-Heinz Jähnick (talk) 18:59, 2 October 2016 (UTC)

Your code already works at Module talk:Version 2. Missing was some adaptions at line 493 and 506 (Module Version 2). Those part deals with overwriting Wikidata content with local data. I have added a comment line into the code for that. The keypoint in that part of the code is "localFrame.args". "frame.args[1]" for example reads the Qnumber of the race written in the Wikipedia article. Sometimes the data is moving from the Wikipedia article through a template to the Lua module and sometimes there is no template. Therefore the code has to check if there is a template (that is done near the top of the function). "localFrame = frame:getParent()" is for the case there is a template and "localFrame = frame" if there is none. I have learned that by looking at the Lua bable box, someone at eoWiki has build. In the bable box editors tell in the article what language the box should show, that is the same task. Looking at other peoples code is always a nice way to learn and get new ideas. -)) PS: I will test the new code tomorrow. --Molarus 22:35, 3 October 2016 (UTC)

For me, some parts of the code are chinese. But I try to learn little to little. Jérémy-Günther-Heinz Jähnick (talk) 09:41, 4 October 2016 (UTC)

The update is at WDwiki and frWiki. You can see an example at fr:Utilisateur:Molarus. I think it was user Douglasfugazi from esWiki who added the team member at Q15303445 without start- and endtime. Instead he/she added the season-article, that is wrong. After adding more data to this rider the table at es:Boyacá_Raza_de_Campeones#Plantilla_2016 showed the previous team too. In that table, I see the "black" rider name "Diego Ochoa". That means, there is an article with the same name, which is no rider at esWiki. (To prevent false WhatLinksHere, the name should be added into the module. I have done that only for enWiki, frWiki and deWiki. And I have a script that helps me to detect false Wikilinks, which I have also done only for enWiki, frWiki and deWiki.) If the update does not create an error in the following days, that I have not seen today, could you give that update to esWiki, caWiki and euWiki too? By the way, I´m running at the moment a python script that helps me to add the occupation-property (P106) to rider-items by hand. Data source for this is the rider-template in the rider-articles. I will do this for a lot of wikis. Someday we have to discuss which bot-job I should do next. By the way, the script works this way: The bot finds all the items that have no P106, print the wikicode of the article at my screen and I press 1,2,3,.. depending on the type of rider: road rider, track rider, cyclocross-rider, ... (or two numbers if someone does two of them, but I have developed that only a few days before. Which means, the fist edits miss a lot of P106.) dewiki has some articles about riders who play ball with their bicycle. (en:Cycle ball), but we have no item for a Cycle ball rider. There is also en:Cycle polo. I have seen that the catalan wiki has around 6000 rider items. It seems they are really cycling crazy, regarding that cawiki has only 500.000 articles. --Molarus 01:39, 5 October 2016 (UTC)

OK. I update the Wikipedias you ask. Then I update the documentation of infobox.

I have another idea today. On some old race, as the fr:Tour de France 1983, we have another classification for teams, not based on time but based on points. So I create the item winner of the teams classification by points (Q27104269) and enter text on the module for infobox. This way, that gives me ideas for stage infobox.

The case of the catalan Wikipedia is very interesting : Herodotptlomeu make a very big work since years. But it not only concern cyclists, he do the best articles on cycling teams of all Wikipedias, informations are very good and they have on CA Wiki the best collection of articles about teams. I sometimes see a very big work for articles about old races.

I continue the work of preparation for stageinfobox. Jérémy-Günther-Heinz Jähnick (talk) 14:55, 5 October 2016 (UTC)

Again an example with ca:Magiglace-Juaneda, a french cycling team of 1974. Jérémy-Günther-Heinz Jähnick (talk) 15:53, 5 October 2016 (UTC)

1) I will add that to the infobox. 2) Do you want the stageinfobox from fr:9e_étape_du_Tour_de_France_2016? I´m afraid not many wikis will use this infobox, because not many wikis have articles about stages, and therefore I will not add all the features of the main infobox, like references, overwriting and team data. By the way, I have seen the main infobox in use at no:6. etappe av Tour de France 2016. 3) It is rather bot-like. I have worked that way myself as I have created the 30+ articles like de:L’Île-des-Pins. The work was checking the data in the internet, googling for anything about that place in the internet and adding that info into tables, which are copied from the former article. That does not make fun, but it is necessary. --Molarus 16:09, 5 October 2016 (UTC)

It think that if few Wikipedias currently create articles about stages, it is just because they are not enough to create one article by day of race. If datas are available, they will create articles. I say that because I see since september we have a raise in the number of creation of articles. Not because we have users, in more, just because datas are available (infobox/teams/classifications). So with an infobox, I can predict a boom in the creation of articles about stages. This infobox will be very different of infobox on some parts. I take again few days to develop a documentation and search new ideas. Jérémy-Günther-Heinz Jähnick (talk) 18:04, 5 October 2016 (UTC)

I have changed the english translation to "Team points". It is shorter and I have seen that at en:1984_Tour_de_France#Team_points_classification. It looks like Module_talk:Version_2. I will test the code later or tomorrow. --Molarus 15:48, 6 October 2016 (UTC)

The code is at WDwiki and frWiki, example fr:Tour de France 1980. --Molarus 02:16, 8 October 2016 (UTC)

Thank you. Jérémy-Günther-Heinz Jähnick (talk) 08:39, 8 October 2016 (UTC)

stageinfobox

Hi Molarus. I take the time to think at a new Wikidata infobox, for stages this time.

• The main color will be #FFE7A0. We have a kind of hierarchy with colors, a stage arrive after a classic race. We have an example on fr:Prologue du Tour de France 2004.
• I start to write a documentation on Wikidata:WikiProject Cycling/Documentation/stageinfobox
• If the stage is a time trial, the logo of the infobox is , not . It is a reference to special wheels and helmets uses in this type of stages.
• The field course is built by concatenate to informations, series ordinal (P1545) and part of (P361). With our example, we will have 2^e étape, Tour de France 2016. The comma is used because we can have in French different words to links these two fields.
• The field for the type of stage takes instance of (P31) and associate the logo at the value. If the value is round (Q18131152), it is useless to display the line. It will arrive for old editions of stages.
• For the rest of fields, functions have been developed for infobox.
• For the different winners, I have thinked to an idea : do like the old infobox of Wikipedia on fr:2e étape du Tour de France 2004 : we will associate teams to cyclists, but this information will be written a line below. The infobox is wider, and we will use this place to write in small additionnal datas like race time (P2781), time gap (P2911), speed (P2052) or points for (P1358) (or number of points/goals/set scored (P1351), it is always a problem with these two properties). At the maximum a cyclist can have two datas associated, it can be the time and the average speed. Because we can have time trials, the algorithm should be able to recognize teams for the 1st, 2nd and 3rd of a stage.
• For files, we will use image (P18) and speed (P2052) for the image at the top of the infobox. At the bottom, we will use locator map image (P242) but also sectional view (P2713), even if it is rare we have these files.
• At the bottom of the infobox, we will use follows (P155) and followed by (P156). Because we can know the series ordinal (P1545) of these items, we can display it to have in French 1^re étape and 3^e étape. If series ordinal (P1545) = 0, the programm will display Prologue (and we have translations for this). We can also have halves stages, but listofstages is able to recognize them and do a good display. During the period of test, we will ask to our contacts more informations to have perfect translations.

I hope this infobox plus the other fonctions will permit to the maximum of Wikipedias to have articles about stages. Jérémy-Günther-Heinz Jähnick (talk) 16:03, 10 October 2016 (UTC)

I think the key to this function is the part of the code that creates the output. In the main infobox a lot of "if .. then" are used for that. I will try to write a loop instead, with using test data and add the code for reading real data from WDwiki later. This way we could see what the output will look like with several WDwiki data missing or with long rider and team names. If the new code for creating the output is a lot better than the old one, maybe we could use it for the main infobox too. I will start with that today or tomorrow. --Molarus 03:43, 11 October 2016 (UTC)

I already have a first version: Module talk:Version 2. I´m not happy with that. Maybe you have thought to use words like "Vainqueur" as tool tip? And I do not like that "m.t." has as much space as "4 h 18 min 39 s", if there is no speed data. --Molarus 17:11, 12 October 2016 (UTC)

It is not a big problem, the module will evolve and we will can bring corrections. Jérémy-Günther-Heinz Jähnick (talk) 17:51, 12 October 2016 (UTC)

The first column is new, the points below the number are from itWiki. I have not found a solution to show the question mark at the picture too. I have choosed a background color to better see the jerseys. Now, the jersey is a wikilink to an article at frWiki. Maybe it is possible to use the jersey as wikilink ('imagemap') if there is a local article or we show the tooltip. At the moment, I don´t know what item to use for that. What do you think about the first column? Any wishes? About rider and team name: At the moment I think, if there is time and speed data, the team name should be written behind the rider name in brackets, not in an additional row. And the infobox has a max-width of 325 pix now. --Molarus 09:20, 15 October 2016 (UTC)

I prefer my solution. If the jersey can appear to be a good idea, colors have changed with the time. Good idea for the brackets, it is not a problem if the infobox is wider. For datas as speed, time and others, these datas will be add now when we will fill winner (P1346). Jérémy-Günther-Heinz Jähnick (talk) 12:21, 15 October 2016 (UTC)

Other idea finally : we can do as infobox and write the text. But if there is an associate jersey, we can display it juste before the text. The algorithm is able to recognize the race (Tour of France, Italy or Spain) and thanks to the articles, we know the colours of jerseys. Note it can be long to code, see fr:Classement général du Tour d'Espagne or more easier fr:Classement par points du Tour d'Italie (just two colors along the time). Jérémy-Günther-Heinz Jähnick (talk) 10:01, 17 October 2016 (UTC)

You are right, what icon are we going to show if we do not have a jersey added into the item? Maybe, we have to show text and find another design for the third section of the stageinfobox? Or we could show a neutral icon, maybe a box or a point, for those cases.

At the moment, I´m writing code to transform qnumbers into text. I think, I have found a good solution for that. It already works for the start- and endplace and for rider- and team names. Maybe I can already go the the next stage and start writing code to read data from Wikidata.

I have taken the word "Points" in e.g. "50 Points" from stageinfobox_translate. I´m not sure if I can do that, because the first letter is always written as a big letter "P", never as "p". --Molarus 16:14, 17 October 2016 (UTC)

I think we will take a similar idea than ES Wiki at es:Tour de Francia 2014 : we have the word for the classification, and if we are able to know the jersey, we display it. Fortunately we have articles about jerseys so we shouldnot have problems.

For the points, we write pt if we have one point, and pts when we have two or more points. If necessary, I can ask to other users when I will give them the function.

I don't understand your second point. Jérémy-Günther-Heinz Jähnick (talk) 12:59, 19 October 2016 (UTC)

I´m using Q21155349 (Tour de France 2016/Stage 8) and I have added some more time data and two points data into the item. Still missing is the code to read gender data and the jersey data. All those data is only from P1346. I have seen that the two other classification properties have jersey data. Maybe I should look in all three classification properties for jersey data? --Molarus 18:46, 20 October 2016 (UTC)

Or we can code the jersey following the articles we have on Wikipedia. With this solution, it is more easy. If it change, we add a new line of code. Jérémy-Günther-Heinz Jähnick (talk) 20:02, 20 October 2016 (UTC)

For example the content of article en:Cycling jersey? We would have less data to add into WD, I see the advantage. For coding that, I think, we need this data: The item of the race (Vuelta a España, Tour de France, ...), the item of the jersey, the type of jersey (General leader, Mountain leader, ...) and the year of the race.

if race == "Tour de France" then

Mountain leader = "Q123", "1980", "2010"

Mountain leader = "Q345", "2011", ""

General leader = "Q789", "1950", ""

if race == "Giro d'Italia" then

Maybe this way? What do you think? --Molarus 23:24, 20 October 2016 (UTC)

Yes, if the race is a Tour de France (Q33881) (easy to know, each stage have a part of (P361), and in the item written in part of (P361), we have a statement for instance of (P31)), the leader of the general classification wear yellow jersey, general classification (Q24257871) but only since 1919, the leader of points classification wear green jersey, points classification (Q24645209) from 1953 to 1967, red jersey, points classification (Q26919974) only in 1968, and green jersey, points classification (Q24645209) since 1969... the fain with the items of jerseys is they are already in use in classifications, so we generally have good translation, that will let appear the description of the jersey for readers. Jérémy-Günther-Heinz Jähnick (talk) 08:24, 21 October 2016 (UTC) I add en:1989 Tour de France for the rendering. Jérémy-Günther-Heinz Jähnick (talk) 10:38, 21 October 2016 (UTC)

I have a proposal for a new table design for the last section:

Lieu d'arrivée	Bagnères-de-Luchon
Classements annexes à l’issue de l’étape
Points Mark Joaquim Rodríguez 4 h 57 min 33 s (37.103 km/h) Team Team Team Team Team Montagne Mark Joaquim Rodríguez 200 pts Team Team Team Team Team

I´m not sure about the jersey in brackets, but this way the connection to the word "Montagne" is stronger. By the way, many wikis have shorter ways to print the time, for example 4h 57' 33", which is the version I would prefer. And there is a third point about the infobox at Module talk:Version 2. I´m not sure anymore that the team in brackets is a good idea. It does not help much. I would like to write the team name into the second row without a bracket. I will code other thinks at weekend, this way we have more time to decide. --Molarus 19:15, 21 October 2016 (UTC)

Maybe we can choose to display the jersey before if it exists. I am intesrested to have the team in brackets, as we do for infobox, and to have in small letters informations as time, gap, speed, points. For the color, I don't like the grey (it is too much '90s), I try another colour (with a program similar as paint, and on the entire infobox), and it is better, this yellow #FFE7B9 is a little different. All participate to make a kind of "hierarchy" : the ranks or jerseys in bold and with a background colour, cyclists, their teams with brackets, and additional informations in small (80 % if my memory is good). Jérémy-Günther-Heinz Jähnick (talk) 13:36, 22 October 2016 (UTC)

Yellow is OK, but it should be less bright. It is as bright as the yellow of the headings, which is not good. The only reason for this color is, that this way we do not have a white jersey on a white background. Now, I have taken as color proposal #ececdf. I have used the program at http://www.w3schools.com/colors/colors_picker.asp The color is your decision, because my screen is rather old and don´t show colors properly.

The reason why I proposed the text first and the jersey last is that this way the text tells the reader where the new data starts. It is more difficult with the text in the middle, but maybe the flag in front of the rider helps.

I will start with that on Monday, this weekend I will do at least the wikilinks for the previous and the next stage. Table listofstages should have the code for generating the label.--Molarus 15:51, 22 October 2016 (UTC)

Thanks to the website you give, I found a new colour for columns : #fff2cc. We have a good yellow. It is bright, but clearer.

I see the infobox this morning with the Triptyque (it was my first stage race in Belgium...), and it is very good. Jérémy-Günther-Heinz Jähnick (talk) 09:09, 23 October 2016 (UTC)

Nice photos at commons:Triptyque des Monts et Châteaux 2014, étape 2a. Do you know that we will have next year or the following year Wikidata for Commons? (commons:Commons_talk:Structured_data#It.27s_alive.21) That means each(?) commons photo will have an item. I think the main advantage will be that it will be easier to search for photos. --Molarus 14:18, 23 October 2016 (UTC)

It is again difficult to imagine, but I think it will be interesting, especially for translations. Commons is not efficient, even if I am the 4th user of this website by the number of file taken and uploaded, I don't like it. I just use it to upload photo and it is finish. It is better to work on Wikidata and see then that articles birth in different languages.

It was my first time trial. But it is difficult to do good photos with bad material, that is why I will see for next season. Jérémy-Günther-Heinz Jähnick (talk) 18:07, 23 October 2016 (UTC)

Pictures at the top and bottom are missing and the header "Généralités". I think, I have all the other small things. Next and last big step is the code for the jerseys. I do not know if we should have next to the jersey data in the module also code to read jersey data from the item. And I think we could add to the jersey data in the code the qnumber of the wikipedia article of that jersey. For example item Q927157 for mountain jersey for Tour de France. I have already tested the code at frWiki and I have corrected some small errors, therefore there should not be any big error. It will not be easy to copy the code from the other module to this module, because I have changed functions which are used by other tables too. Testing will last some time. I hope the code could be moved to frWiki at weekend. --Molarus 00:12, 26 October 2016 (UTC)

Hi Molarus, and sorry for the late. For me, all is OK except the colors for the infobox. #FFE7A0 is the main color, the second color is #FFF2CC. We should have #FFE7A0 for the title and headers and #FFF2CC for the types of places. If you want, I can list the different jerseys and time for the three Grands Tours. Jérémy-Günther-Heinz Jähnick (talk) 13:37, 29 October 2016 (UTC)

Yes, the color for "Généralités" was wrong. The jerseys in section "Classements annexes à l’issue de l’étape" are already done. The green jersey links to a nlWiki article (I have coded at the moment, that WDwiki uses nlWiki articles). I will code today that the yellow jersey will show "Leader" as tooltip and link to a Wikipedia article too. At the moment, I do not need more jersey data. Tomorrow, the code will be moved to this module. --Molarus 19:06, 29 October 2016 (UTC)

I have added code to show the word "Combatif", if there is no jersey. Jérémy, could you create an item for a jersey with a red and a yellow number (combatif and team), we do not have them so far. Have a look at the yellow jersey. The tooltip says "leader" and it is a weblink. I think, with a jersey item for "combatif" added into the code the word "combatif" will disappear. --Molarus 20:52, 29 October 2016 (UTC)

I create yellow bib, teams classification (Q27644112) and red bib, combative rider (Q27644113). I prefer if we can keep fields as Leader or Combatif, and add the jersey in front of these words and on the same line. I have a look on fr:8e étape du Tour de France 2008, and by experience, a person that don't really know the race is not able to guess what classification depend the jersey, it was my case by the past, and it is better if it is written directly. And finally, I am interested if the first columns can all have the same width, I am a little (big) maniac.

This way, I will make first tests of the module tomorrow at the end of the day (I have a timetable of minister in this period). Jérémy-Günther-Heinz Jähnick (talk) 17:26, 30 October 2016 (UTC)

Maybe you have not seen that now all the jerseys are wikilinks and they show text as tooltip. On the other side, there is not as much waste of space as in the example "TDF 2008". Making the first column to have the same size in all sections would mean a big waste of space and I would have to rewrite the whole table. At the moment, I´m using lots of tables to give each first column its own size and giving the whole infobox the same size means changing all that. By the way, I have seen that time, point and speed data is available but is not shown in the infobox. I have to fix that. --Molarus 18:52, 30 October 2016 (UTC)

It seems that only in "2016 Tour de France, Stage 8" time, point and speed data is at P1346. In other stages that info is at two other properties and I have no code to get the data from there. That means, the code is not done, sorry. --Molarus 19:10, 30 October 2016 (UTC)

No problem, we have all our time. On my side, it rest again data to enter on Wikidata to prepare examples on FR Wiki, and I will give after these examples when I will give the function, and it rests again translations to ask at our users. Jérémy-Günther-Heinz Jähnick (talk) 19:34, 30 October 2016 (UTC)

I have done the code. Not efficient, but in a short time. I have taken the example of Q26209129, where even most of the winner names are not inserted and now the names have been taken from the two classification properties. This is an example of a team time trial. I this case there is no rider gender, so I have to take female gender. I will code that today too. I wonder if that is true for other languages too. I guess there will be more things missing or not working properly. I will try today to move all the code to this module and maybe I can start testing too. Since tables outside table stageinfobox will be involved, please be carefully with copying the code to frWiki. --Molarus 20:54, 30 October 2016 (UTC)

The code is now also in frWiki and I have already found some problems.

• I have at my user page fr:Utilisateur:Molarus the race "2ea étape du Triptyque des Monts et Châteaux 2014". This is taken from the label of the item. The label says "2ea" but it is "2^e a". I think, I have fixed that for frwiki, but maybe other languages will have the same problem and it is not fixed for them. No, it is not fixed for frWiki, only for the case "2ea".
• The example at Modèle:Cycling race/stageinfobox have previous and next items without a series ordinal. In this case now we show at least arrows.
• And it seems I have to adjust the vertical align of the first column
• I will look if the new lua code breaks in some articles

--Molarus 23:19, 30 October 2016 (UTC)

I start some tests at fr:Modèle:Cycling race/stageinfobox. Jérémy-Günther-Heinz Jähnick (talk) 13:24, 31 October 2016 (UTC)

The errors are fixed (WDwiki, frWiki, not at daWiki), but there are still design errors, I think. --Molarus 21:37, 31 October 2016 (UTC)

We will find them little to little. Interesting your code to display the title of the infobox. I start tries and I see rare points for the moment :

• on the first example, it lacks the display of sectional view (P2713). The code is the same as locator map image (P242) except here we work with another type of graph. Note that it will be possible to have a card and a profile, it will be very rare but it is not a problem.
• It lack the little logos just before the name of the type of stage.
• The jerseys should be at the same level that their classification.
• A cyclist can loose its place due to doping. In this case, we have a qualifier reason for deprecated rank (P2241) with cyclist declassed due to results cancelled due to doping (Q22039296). The name of the cyclist should be striked. I think there is no need to write more datas because in these cases, users generally write a paragraph in the article.
• The prologue is always a time trial, with a different logo.

After, I will discuss with Anthony59999 to ask him its opinion about specific cases. Jérémy-Günther-Heinz Jähnick (talk) 18:21, 1 November 2016 (UTC)

				{'Q33937', 'leader', '+1935', '+1936', 'Q24258056', 'Q3278226'}, -- Vuelta a España, Jersey orange.svg
				{'Q33937', 'leader', '+1941', '+1941', 'Q26696171', 'Q640430'}, -- Jersey white.svg
				{'Q33937', 'leader', '+1942', '+1942', 'Q24258056', 'Q3278226'}, -- Jersey orange.svg
				{'Q33937', 'leader', '+1945', '+1945', 'Q24257872', 'Q2534046'}, -- Jersey red.svg
				{'Q33937', 'leader', '+1946', '+1950', 'Q26696171', 'Q640430'}, -- Jersey white.svg
				{'Q33937', 'leader', '+1955', '+1976', 'Q24257871', 'Q738903'}, -- Jersey yellow.svg
				{'Q33937', 'leader', '+1977', '+1977', 'Q24258056', 'Q3278226'}, -- Jersey orange.svg
				{'Q33937', 'leader', '+1978', '+1998', 'Q24257871', 'Q738903'}, -- Jersey yellow.svg
				{'Q33937', 'leader', '+1999', '+2009', 'Q24257991', 'Q27665179'}, -- Jersey gold.svg
				{'Q33937', 'leader', '+2010', '+2500', 'Q24257872', 'Q2534046'}, -- Jersey red.svg
				{'Q33937', 'points', '+1945', '+1986', 'Q24687409', 'Q2746711'}, -- Jersey blue.svg
				{'Q33937', 'points', '+1987', '+1989', 'Q24645209', 'Q11638007'}, -- Jersey green.svg
				{'Q33937', 'points', '+1990', '+2009', 'Q24687409', 'Q2746711'}, -- Jersey blue.svg
				{'Q33937', 'points', '+2010', '+2500', 'Q24645209', 'Q11638007'}, -- Jersey green.svg
				{'Q33937', 'montagne', '+1935', '+1985', 'Q27670182', 'Q11638007'}, -- Jersey green.svg
				{'Q33937', 'montagne', '+1986', '+1986', 'Q27670174', 'Q3278226'}, -- Jersey orange.svg
				{'Q33937', 'montagne', '+1987', '+1987', 'Q27670178', 'Q2534046'}, -- Jersey red.svg
				{'Q33937', 'montagne', '+1988', '+1989', 'Q27670105', 'Q27670115'}, -- Jersey blackdots.png
				{'Q33937', 'montagne', '+1990', '+2005', 'Q27670182', 'Q11638007'}, -- Jersey green.svg
				{'Q33937', 'montagne', '+2006', '+2008', 'Q27670174', 'Q3278226'}, -- Jersey orange.svg
				{'Q33937', 'montagne', '+2009', '+2009', 'Q27670126', 'Q27670163'}, -- Jersey granate.svg
				{'Q33937', 'montagne', '+2010', '+2500', 'Q25265959', 'Q27670167'}, -- Jersey bluedots.svg

At frWiki only "Équipe aux points" is really long, but at daWiki, they write "Holdkonkurrence efter point". I have developed code to make a line break after "Equipe", which you can see at this page. But "Holdkonkurrence" is still a long word. I think, I have to set the width of the infobox depending on the wiki. That means, dawiki would get a stage infobox with a width of maybe 350px or 375px. --Molarus 22:01, 1 November 2016 (UTC) !I think it is not a problem to have a wider infobox. On Wikipedia, the big part of infoboxes have two columns where we have here three columns and naturally need more place. Jérémy-Günther-Heinz Jähnick (talk) 09:45, 2 November 2016 (UTC)

I'll try to shorten the terms as "Holdkonkurrence efter point" to "Hold efter point", "Bjergtrøje" to "Bjerg" and so on. I can't find a Danish translation for the French "Étapes volantes" and "Régularité", do you know a good english translation for it? :-) --Hejsa (talk) 23:38, 2 November 2016 (UTC)

@Hesja: : I bring an english translation. We can translate the first by metas volantes that is used even in english, and the second by regularity, this classification is not so different from the combinated. On another point, I launch a new proposal for new properties on Wikidata:Property proposal/Event. I need votes because we will need these properties for the future functions. Jérémy-Günther-Heinz Jähnick (talk) 13:51, 3 November 2016 (UTC)

Now dawiki has the small stage infobox, while nowiki gets the large one. --Molarus 21:08, 3 November 2016 (UTC)

@Jérémy-Günther-Heinz Jähnick: I will try with "indlagt spurt" (intermediate sprint) for "metas volantes" and "regularitet" for "regularity", but I have not heard of that term in cycling before :-) How do I vote? --Hejsa (talk) 21:41, 3 November 2016 (UTC)

@Hesja: : it is because I have a "little game". We are enought to write articles about 2016 races and soon 2017 races, and the progress we make to centralise datas here let me see I am useless, so I sometimes spend my time to enter datas about old races, and in these old races, we have this type of classifications. For the metas volantes, this classification is again in use about spanish races, and the goal of this program is to be able to adapt at all cases (that is why it is complicated). For the vote, you can go at the bottom the page and explain why these properties will be interesting for the Danish Wikipedia. By experience, these proposals are sometimes a battle because some users want impose their views where they never work in a domain, and it is sometimes hard to explain that to be adotped, a system must be very very easy. Jérémy-Günther-Heinz Jähnick (talk) 10:58, 4 November 2016 (UTC)

About "reason for deprecation": I have found the item Q3832109 (Liège-Bastogne-Liège 1981, a one day race). You have said you want to show the name of the rider striked. In this example this rider has a "depreciated rank" and the new number one is added with a normal rank. In this race, rider three has also a "depreciated rank". With a quick solution this item looks like Module talk:Version 2: The new number one and no number three. The solution with the name of the rider striked is more difficult, because I have to show an additional rider name. About the width of the stageinfobox: Now the code has as standard max-width 320 pixels. max-width mean, that it could be less then 320px. Only if the last section is shown and the wiki is dawiki max-width is 340px. I have tested that with dawiki words and it seems OK for me. If there are more wikis with long words, just add the wiki into the code. The code for that is where the width of the table is written in the code. If you accept the no-strike-solution, I think all the fixes are done (code is only at WDwiki). --Molarus 22:01, 2 November 2016 (UTC)

If have another example in head where the ranking was not modified, like we have on fr:Prologue du Tour de France 2004. But two cyclist for one rank should not be a problem, I have in head races where cyclists are ex-aequo (by the past, now they are able to define a winner even at one centimeter) but also the fr:Duo normand 2015, an original race.

Now, I´m showing at Module talk:Version 2 the third rider too, but striked. I don´t think I can find a solution for an additional striked leader without spending a week or more on that problem. The reason is, I would have to create for each winner a possible striked winner to show both in the infobox. If you accept this solution, I have to write the code for all three classification properties, at the moment it is only at one classification property ('P2321', general classification). By the way, we do not show references at stageinfobox. --Molarus 21:08, 3 November 2016 (UTC)

The time is not a problem in this moment, it will surely takes time before the requested properties will be created, so we will cannot work on other functions. Jérémy-Günther-Heinz Jähnick (talk) 10:58, 4 November 2016 (UTC)

I present the function on FR Wiki and start tests into articles. On fr:16e étape du Tour de France 2016, we have two cyclists that are most combative rider (Q21686770), but only one is displayed. Jérémy-Günther-Heinz Jähnick (talk) 17:36, 6 November 2016 (UTC)

Done, see #2016 Tour de France, Stage 16, Q21155401. Code is at WDWiki only. Do you see any consequence from this for us? Wikidata:Project_chat#Results_of_RfC_about_Wikidata_in_WP:fr? From what is written at Wikidata:Project chat, I would say no. --Molarus 01:31, 7 November 2016 (UTC)

Perfect ! You can see examples on fr:Catégorie:Étape du Tour de France 2016.

For the RfC, here called Prise de décision (decision making), it is even very good for us :

1. Sourcing is not mandatory (here, we use statements with Cycling archive, Cqranking and/or ProCyclingStats)
2. We are free to display references incorporated on Wikidata (we do this, with the first phase, it was refused to use Wikidata in references, but it was in contradiction with a second pillar according to my interpretation)
3. We somebody read an article, he must be able to guess the datas come from Wikidata (we do this always thanks to the small Wikidata logo)
4. When there is a data in an article, it is forbidden to link it directly to Wikidata (example if we write the name of a cycling, and by clicking on it, we go on Wikidata, that is why we use red links)
5. It is forbidden to write d:Q36180 in an article (that is why we use generally the english label if a translation lacks)
6. If we decide to make new improvements on one of our functions ; if we decide to create a new function and include it on several articles, asking authorization of members of fr:Projet:Cyclisme is not requested, no authorization is needed (here, it is very interesting because there is a little number of users that often makes problems ; by experience, I generally discuss with our contacts).
7. If I replace an old infobox by stageclassification, I must verify before publishing that all is good and we have no contradictions. I there is a contradiction, I must solve the problem (but we do this since the beginning, and using Wikidata has permitted to solve mistakes).
8. If we want to display informations from Wikidata in an article, we must use a template and not do it directly in an article (we always have used templates, it is better because it can evolve with the time).
9. We must be able to display a local data more precise that a data from Wikidata and the documentation must explain it (and we have do this, especially for listofstages ; because we have also take the party to be able to write a maximum of datas in Wikidata). Datas written like this must not change the display of the template.
10. It was refused that all parameters of an infobox that is able to work with Wikidata are always displayed on Wikipedia (and fortunately).

It is just a summary. According to me, changes are very good because definitively I no longer need to discuss with a few number of users that are responsible of delays since last year (in facts, I already say them I don't work with them). This time saved, I will can spend it to other users from other Wikipedias. It is interested, because we have "predicted" all these points since months. For FR Wiki more generally, it will be good because users will can spend their time in solving bugs instead of fighting with opponents. One year was lost due to a hand of people. It was the reason I work on Wikidata, this way, I was very discret and nobody really makes problems about the new uses we made of Wikidata. Jérémy-Günther-Heinz Jähnick (talk) 18:41, 7 November 2016 (UTC)

At deWP we do not have such a community decision, maybe frWP is the first. I would say the result is good Wikipedia commons sense. And as longtime Wikipedia editor, I wouldn´t do it otherwise too. I´m glad the frWP has decided this way. --Molarus 00:53, 8 November 2016 (UTC)

Me too. This is interesting because it shows that without setting clear rules, contributors will be able to decide case by case without any more bureaucracy. It's like Wikipedia found there ten or fifteen years. Jérémy-Günther-Heinz Jähnick (talk) 15:10, 8 November 2016 (UTC)

I continue tests. On 21e étape du Tour de France 1989, I discover that the function don't work when it is a last stage, in these case, cyclists are not leaders by winners of a classifications and items are different, they are the items written in small letter in the documentation. Jérémy-Günther-Heinz Jähnick (talk) 17:11, 9 November 2016 (UTC)

Done. Code is at WDwiki and frWiki. I have also found that the item of the "Classement du meilleur jeune du Tour de France" was wrong. --Molarus 04:50, 10 November 2016 (UTC)

Thank you. On my side, I continue to apply it and it works very well. I detect a problem on fr:Prologue du Tour de France 2012 where we have a statement for locator map image (P242) and another for sectional view (P2713) but the function display only locator map image (P242) where I should have one image and another just after, it is the rare case where we have the chance to have a card and a profil. Jérémy-Günther-Heinz Jähnick (talk) 18:39, 11 November 2016 (UTC)

Done. It is live at frWiki and WDwiki. By the way, I will be offline from mid-December to the first days of 2017, as last year. --Molarus 06:57, 12 November 2016 (UTC)

For me, it is possible I work from the 1st december. My skills are required, but I have to negotiate very satisfactory conditions beforehand. I no longer wish to live below the poverty line. I hope being able to be online at least 15 min by day. Jérémy-Günther-Heinz Jähnick (talk) 17:05, 12 November 2016 (UTC)

Good luck with that job. --Molarus 09:18, 13 November 2016 (UTC)

teamroster and countries 1

Hi Molarus. Since few months we have an h@rr@sser on FR Wikipedia who follows all my edits and revert all of them when he see I use 'teamroster because "there is not a column that write the name of the country" just flags. Due to its behaviour, there are problems to make updates for everybody. Do you think it is possible to add a column for the country of nationality between the date of birth and the previous team ? Jérémy-Günther-Heinz Jähnick (talk) 18:54, 11 November 2016 (UTC)

It is no problem to add that, but the result would be the same as in the classification tables. What about creating a second user account or editing as IP? --Molarus 06:18, 12 November 2016 (UTC)

We could write the names of maybe 50 countries into the code, while all the other coutries get the information from Wikidata. I could do that such that the country names are in a second module, which is only for frWiki. This way those wikis who want the country names to show have to create such a second module. Maybe this could be a solution for the classification tables too. This is no big coding task, maybe one or two weeks of work. --Molarus 10:24, 12 November 2016 (UTC)

It is just for teamroster. For all other functions, this user says nothing... It is more difficult to understand humans than computers (it is a joke but it is true). Jérémy-Günther-Heinz Jähnick (talk) 16:57, 12 November 2016 (UTC)

I will try this for the classification tables and if it is possible to fix the frwiki articles this way (no lua error anymore), we could think about using that code for teamroster and tooltips for flags too. See you in two weeks. --Molarus 08:48, 13 November 2016 (UTC)

The basic version is to be seen at Module talk:Version 2. The new module is Module:Cycling race-WD with the country names of Italy and France (in german now). Each Wikipedia could decide on its own which and how many country names should be in the local translation module. There is not much new code needed to use the new module, at the moment just two new lines of code. I think each local translation module should have a different name, at frWiki "Module:Cycling race-fr", at enWiki "Module:Cycling race-en". Or maybe all could have the same name like "Module:Cycling race-lang"? I will code that later. --Molarus 06:31, 14 November 2016 (UTC)

Why not Module:Cycling race-Countries ? This way, we have a name not following the language but following its function. Jérémy-Günther-Heinz Jähnick (talk) 10:12, 15 November 2016 (UTC)

Or Module:Cycling race/lang? I don´t like "Countries", because if all wikis have a second module in the future, maybe all translations could be moved there. I have changed the language of the countries into French, for moving them to frWiki. --Molarus 11:10, 15 November 2016 (UTC)

Ah yes, lang is better. Jérémy-Günther-Heinz Jähnick (talk) 09:51, 16 November 2016 (UTC)

The new code and the new module (fr:Module:Cycling race/lang) is at frWiki. Lets see if all the cycling articles at fr:Catégorie:Page avec des erreurs de script will be gone (There were a lot of women races in that category). There was a small error in the timetrialclassification table, but I hope that tomorrow none of our article will be in that category. The new code will show the country names only if there is the second module, otherwise only the flags. I hope, this way editors can add more then 3 or 5 rows per classification table again. If the category is clean tomorrow, I will start adding the code for the team table too. At the moment 26 country items are in the new module. We have in the history of this module a lot more items, because we started this module one year ago with 300 countries in the flag function. I can add more items, but maybe those 26 items will be enough. --Molarus 19:13, 16 November 2016 (UTC)

Sorry for the late. We will see how it works and if we must add countries. I remember this list of countries. When all will be perfect, I will see with our contacts if they are interested by this option. On my side, I continue my experience with the year 1980, and I will see if we can add specific classifications to stageinfobox. Jérémy-Günther-Heinz Jähnick (talk) 13:05, 19 November 2016 (UTC)

I have thought about the place of the country names in table teamroster. Have a look at Module talk:Version 2. What do you think? The missing country names are the countries without data in the new module, I have to get the names for those countries from wikidata or I´m adding the data to the new module. Five missing country names would slow the module by maybe 0,5 seconds. --Molarus 18:08, 20 November 2016 (UTC)

The result is perfect, can you add a parameter line-height: 1.8em; to have a table with more air (more space, the french is plus aéré). Jérémy-Günther-Heinz Jähnick (talk) 13:05, 28 November 2016 (UTC)

Thank you, I made a test with 1.8em instead of 1.6em. All is perfect. Jérémy-Günther-Heinz Jähnick (talk) 14:58, 28 November 2016 (UTC)

What about moving the code to all wikis? At the moment only frwiki has the new code. --Molarus 15:09, 28 November 2016 (UTC)

I am for this idea. Jérémy-Günther-Heinz Jähnick (talk) 17:46, 28 November 2016 (UTC)

The code is life at WDwiki. I have tested the code at WDwiki, frWiki and deWiki. With the new code the lua time for article de:Eneco Tour 2016 would reduce from 6 seconds to 3 seconds (at midnight). Therefore, I would recommend to uses this update. I have changed the code for the three classification tables again for the case that there is no new module, which will be quite normal, I guess. They look in this case this way: Module talk:Version 2. I have not seen any error while testing, but we will see if there is really no error only after deploying the new code. --Molarus 00:56, 30 November 2016 (UTC)

teamroster and countries 2

Could you give me an answer to the question at "teamroster and countries"? (about "Pays" column in teamroster table) And the code for the new module is at the moment not at WDwiki, only at frWiki. The new code shows a country name in the classification tables (and the teamroster table), only if there is the second, local module. After that feature is done, I will look into adding code for new features. --Molarus 19:36, 23 November 2016 (UTC)

Sorry, I miss this message (a death in my family disrupt me since few days). The field Pays is at the good place. I will add the name of the countries in the module if necessary. The time to display this is not really a problem, and I think we will have few problems with a reach of the famous limit of 500 function IF. Jérémy-Günther-Heinz Jähnick (talk) 09:44, 24 November 2016 (UTC)

I´m sorry to hear that. Please, don´t add country names, because I have to add code to get country names from WD no matter how many names are in the module and this way it is no problem to develop the code. And the small list is a good list for Wikidata and for translating for local wikis, because this way it is no big deal to get maybe 90% of all countries from the second module without translating hundreds of country names. --Molarus 21:16, 25 November 2016 (UTC)

Sorry, I have sometimes little difficulties to understand nuances in English (in France, the level in foreign languages is very low), and I understood the fact there is few countries can be a problem, where finally it is the contrary... Jérémy-Günther-Heinz Jähnick (talk) 10:14, 26 November 2016 (UTC)

The code is at frWiki, not WDWiki. And I have added into fr:Module:Cycling race/lang "Tchéquie" and "Chine" instead of what WD would print "République tchèque" and "République populaire de Chine". Maybe there are more such shorter country names? I will look in the next few hours if there are some lua errors and fix them. By the way, I have seen that in edit mode "Éléments Wikidata utilisés sur cette page" show the data taken from Wikidata. It is interesting. There is for example "Drapeau de la Slovaquie". We use that item to get the flag of the Slovaquie, instead of using the item Slovaquie. It is faster this way. At least when "Slovaquie" is taken from the new module. And this reminds me that we could speed up the Lua code by adding more such flag items into the code (function flag). For example the flag of "Tchéquie" is taken from the country item, not the flag item. On Monday, I can start with the new stageinfobox features. PS: I´m not sure, maybe you have misunderstood me. I was sorry about hearing that about you family, not that you wanted to add some data. I should have written that better, sorry. PPS: A big teamroster table like fr:Équipe cycliste Bahrain-Merida needs 1.140 s Lua time at midnight from Saturday to Sunday and the limit is now 10 seconds lua time (7 s before). Number of expensive functions 68 from 500. If the time is not much worse at Monday evening, I think this feature is no problem regarding the time. Maybe there is a space problem, but editors should do something about that by adding the right country name into the new module or by adding a line break into the article. PPPS: No Lua error so far. --Molarus 00:22, 27 November 2016 (UTC)

I think at URSS instead of Soviet Union (Q15180). I have no other examples in my head. I have a look on fr:Équipe cycliste IJsboerke. Yes, there are new improvements on FR Wiki. Ah, no problems. I speak French, you speak German, we communicate in English, generally at the end of the day, it is logic we sometimes misunderstand. For the last point, it was discussed with Psemdel on FR Wiki, because there is no longer problems to display his womens stages races. The problem is the limit of 500 expensive function, I hope a day the will raise this limit. I remember it is old, because I already have problems with this article written mid-2011. Jérémy-Günther-Heinz Jähnick (talk) 09:54, 27 November 2016 (UTC)

I haven't understood everything on how it is done, but it is good idea to shorten the country names. I came for the problem of "Kingdom of Netherlands" which is too long. So I am happy that we are trying to improve this point. In English there is also a "problem" with USA, which is displayed "United States of America". Otherwise there are of course the RDA and RFA (DDR und BRD für Molarus ;)), which are common abbreviations. Race palmarès are no geography lecture, it should be brief and clear. Psemdel (talk) 10:08, 27 November 2016 (UTC)

At frWiki, it is fr:Module:Cycling race/lang. At fiWiki it will be "Moduuli:Cycling race/lang". If there is such a local version, just edit the Qnumber and the name of the country in the local version as you like. --Molarus 21:46, 27 November 2016 (UTC)

stageinfobox : addition of four fields

Hi Molarus. I continue the work on stage infobox. It concerne the Giro d'Italia. Cima Coppi (Q2250962) and Cima Pantani (Q10452933) are the higher and the second higher summit climbed by cyclists during a Giro. We have these statements only one time by race, so only two statement to do each year. The display should be done in the section Résultats de l’étape of the infobox, after a combative cyclist. There is no jersey. I am not opposed to a Wikilink if the article exists. Cima is the italian for summit.

Then we have two items about secondary classifications : leader of the breakaway classification (Q27907714) / winner of the breakaway classification (Q27907715) if it is a last stage ; Q27907748 / Q27907747 if it is a last stage. The first classification, Fuga Pinarello (Q27907691), attribute one point by kilometer for a cycling being in the Ausreißversuch / Escape / Échappée. The second, Azzurri d'Italia (Q27907719), gives points to the three first cyclists finishing stages. Two are points classifications, and we generally have points for (P1358) as qualifier. I am interested if we can have wikilinks is the Wikipedias articles exist for Fuga Pinarello (Q27907691) and Azzurri d'Italia (Q27907719). I will surely create these articles, because it can be interesting for the rider to directly have informations. And for one, it was difficult to understand and to find informations. You have an article using this two lasts fields on fr:3e étape du Tour d'Italie 2014. For the four fields, italian words are used and not tranlated. The Fuga Pinarello classification was created in 2002, and its name varies along the time, I register them in the item.

On another hand, I take contact with an employee of the WMF and ask him if it is possible to transmit this page to a maximum of users. I hope getting translations in Greek (I like the culture of this country), in Chinese (I like seeing the development of this country, very fast), and other languages. Jérémy-Günther-Heinz Jähnick (talk) 14:01, 23 November 2016 (UTC)

I have looked into frWiki to find examples for Cima Pantani and Cima Coppi. fr:19e étape du Tour d'Italie 2016 will have a "Cima Coppi" and fr:14e étape du Tour d'Italie 2016 a "Cima Pantani". Data about "Fuga Pinarello" and "Azzurri d'Italia" is available at fr:Tour d'Italie 2016. I have found an english explanation about the two classements at [1] I guess those two classements are not only to be shown at the stageinfobox, but also at the infobox. [2] gives data for the Tour d'Italie 2016. It seems, 2016 there was no Azzurri d'Italia as fr:Azzurri d'Italia says. Time for coding one or two weeks. --Molarus 03:37, 2 December 2016 (UTC)

Yes, it is exact.

On my side, I am now very occupied but I will try to pass here everyday between 19 h and 20 h generally. 55 km in bike today, 30 yesterday, and 40 two days ago. Jérémy-Günther-Heinz Jähnick (talk) 18:58, 2 December 2016 (UTC)

I have the code for the 4 classifications and I will move them later to WDwiki and frWiki. The items I have used for developing the code and where I have added data into (actually Fuga Pinarello data points for all 2016 Giro d'Italia stages) are Q21074504, Q21074499 and Q16831772. The first two items have a french article with our stageinfobox, the third item has no stageinfobox. The next step is to add code into the infobox table. What I have not done is links to the Wikipedia articles about the classifications. So far the code uses the jerseys as wikilink to the Wikipedioa articles. Since the new classifications have no jerseys, I would have to code something new. I have not thought so far about how to do that. If a big change of the code would be neccesary, I will not do it. --Molarus 11:29, 9 December 2016 (UTC)

Ok, I will follow this, I am at home for few days again (I fell in bike and I am wounded). I will on my side take contact with users to ask votes for properties about classifications. I hope they will be created in january. Jérémy-Günther-Heinz Jähnick (talk) 13:12, 9 December 2016 (UTC)

I have copied the code for showing Fuga Pinarello and Azzurri d'Italia at the infobox module to WDWiki. PS: I´m offwiki from Monday (Dec. 19) for two weeks. --Molarus 18:32, 13 December 2016 (UTC)

Ok. I will profit of this period to update little to little to documentation. Jérémy-Günther-Heinz Jähnick (talk) 11:13, 14 December 2016 (UTC)

One year !

It makes one year we work together and it is a pleasure to meet you because all has changed and it is now easier and faster to work. Jérémy-Günther-Heinz Jähnick (talk) 10:39, 29 November 2016 (UTC)

This project has advanced so much (code and data) and so many editors have joined, incredible. My goal for the next year is to code the phyton bots that will copy data from the wikis to WDwiki, the more the better. --Molarus 01:17, 30 November 2016 (UTC)

"team points" in wiki.de

In the german topic Giro d'Italia 2016 appears the word "team points" wich isn´t the original name "SuperTeam" nor the german meaning, wich is may be "Teamwertung (Punkte)". Could we change ist?--RikVII (talk) 09:36, 10 December 2016 (UTC)

I have changed the word at WDwiki and deWiki, see diff (deWiki). You can do this yourself too. --Molarus 10:27, 10 December 2016 (UTC)

Review on EN Wiki

I am discussing with XyZAn to use Cycling race more widely on EN Wiki. I have the opposition of few users (Wikidata is a "monstruosity"), but by experience on big Wikipedias we always have users that love to work as before, so I will discuss with other users.

One of problem is, I think, not difficult to solve. On other Wikipedias, we have for desambiguation City (Region or Country), and the algorithm remove the text between the brackets and the brackets themselve. On EN Wiki, they use a different system : a comma, so we have like in this example City, Region or Country. So this idea is to display only the text before the comma without changing the link. Maybe we can take the english label from Wikidata. I don't know. For other points, I will directly ask to XyZAn to review one by one the different functions. Jérémy-Günther-Heinz Jähnick (talk) 10:19, 15 December 2016 (UTC)

I have looked into the code. I think, only function WPlink is responsible for removing text between brackets ("string.gsub(Sitelink, "%b()", "")". That code replaces a string like "(...)" with an empty string). The additional code would be to search in the string Sitelink for a comma and replace everything from the position of the coma to the end of the string with an empty string. Therefore it will not be difficult. I could do that at weekend, if you like. What I do not know is, if I could use a comma as sign for all wikis or only for enWiki. --Molarus 10:58, 15 December 2016 (UTC)

I think for the momsent we should just do it for EN Wiki, and then, with the time, see if it i necessary to do it for other Wikis. They use commas for places, but not for other things like roller coasters (one of my first topics on FR Wiki, it was in 2008). Jérémy-Günther-Heinz Jähnick (talk) 13:23, 15 December 2016 (UTC)

The code is at enWiki and WDwiki, see en:User:Molarus. Tooltip and Wikilink are "Unley, South Australie", while "Unley" is printed. I have not tested the code at for example frWiki, but I do not think there will be an error. I have seen, that at "Template:Cycling race/infobox" in enwiki the "Journey origin" has changed from "Fourmies, Nord" to "Fourmies". This fix should change something only at enWiki because I have worked with 'if wiki == "en" then ...' at function WPlink. --Molarus 17:23, 16 December 2016 (UTC)

Errors

I would say some tables on this page are broken now. --Molarus 18:18, 2 January 2017 (UTC)

Hi Molarus and an happy new year. I see that just now, it seems there is a link with the code for not displaying the comma and the word following, due to the number of the lines given by the error message. I see on EN Wiki ten days ago we had a problem with the same update with rosters to display the previous team when there is no article about the team, see en:Sport Vlaanderen–Baloise. We don't have this error on other Wikipedias, so I guess there is a link. Jérémy-Günther-Heinz Jähnick (talk) 09:46, 3 January 2017 (UTC)

Happy new year. 1) Yes, I have created that error with my edit from 16. december, sometimes there is no local Wikipedia article and therefore "Sitelink" has the value nil, which was not in the code. I have also changed "string" to "mw.ustring". The second is for UTF-8 encoded strings, witch means, words written for example in cyrillic could cause problems without using "mw.ustring". I have fixed enWiki and WDwiki. I hope, there is no other error, I will check enWiki. 2) Please tell me if there is anything I should do next or if I can work on some older tasks. For example, I have developed new technologies for function stageinfobox, which increases the speed of that function a lot in comparison to function infobox (lua time 0.5 seconds less). Maybe I can apply that to the classification tables too and save some lua time. And I have remembered that I once wrote some technical documentation at Module talk:Cycling race/doc, which needs some update. With more free time, I could work on my botscripts too. There is a lot to do, where I do not need your support and therefore less of your time. --Molarus 11:45, 3 January 2017 (UTC)

My wish was the properties about classifications were created, but an user try to explain on Wikidata:Property proposal/Event another way to work, and don't understand our users need to work very easily to fill Wikidata. The solution he proposes is not acceptable : we have stage and general classifications, users will never fill one by one the items of cyclists for secondary classifications. I don't know how to explain at ArthurPSmith a system must rest very easy to continue to be developped. I would suggest to start the new function victories because we have a property victory (P2522) but we have very few races in this moment, and I thinks we should spend our time until the 15th january to improve the display of functions for our different users. Like a technical checkup (Hauptuntersuchung in german, to give a similarity with cars). Few days ago, I discusses with @EileenSanda: and @Hejsa: from FO and DA wiki about the way to adapt a maximum the display of the module. I have had interesting responses. Other example, I discuss with @Xabier Armendaritz: to adapt the dates at HU Wiki. It works for listofstages but not for teamroster. In march 2016, Xabier Armendaritz make adaptations for languages in spain. Jérémy-Günther-Heinz Jähnick (talk) 19:04, 3 January 2017 (UTC)

1) I like your proposal for "victories". That new table would be at the same wikipedia article as teamroster, I guess. I don´t think lua time will be a problem. 2) About improvements for existing tables: Good idea. I have read your discussion at foWiki now, it seems you have done everything. 3) About scripts: I wish to write a script that moves team data from Wikipedia rider articles to Wikidata. This way we don´t have to ask editors to add this data to Wikidata. Now that the new season starts, a lot of data is to add by hand to Wikidata. I do not think this is work that should be done by hand. I guess there are some thousand riders where team data should be checked. If we would have a bot for that, this would be a huge step forward, in my view. I have written a good part of that script in November, but there is still some code missing for a first version. Today, I´m still not able to write a bot script that can work without someone to say yes or no to the bot edits or a website where editors tell the bot what to do. harvesttemplates (from user Pasleim, I guess.) is an example for that, but this tool can harvest only easy statements from infoboxes, team data, for example, is not possible to harvest with that tool. By the way, we could also have a bot that copies data from Wikidata into local Wikipedia templates. That means, we do not have to build a lua table to show wikidata content in Wikipedia. --Molarus 02:02, 4 January 2017 (UTC)

1) No, normaly it shoudn't be a problem. Moreover this function will be particular because the datas will always be written because they are already used by other functions. So we will just have a statement to do for each victory. But I think the programming will take time to take in consideration all specific cases. 2) No, it lack the comma instead the dot for figures and the display for previous and next stage, and name of stage in the first line of the infobox. I can also ask to @Douglasfugazi: the same information : how you do to write a stage and a half stages in spanish ? I am interested for the format date in hungarian. It works for the small display but not for the long display with year, and I am not a pro with dates. 3) For new teams, I don't know : I see for 2017 we are in advance compared to some Wikipedias and even FR Wiki, so were are more efficient than in other Wikipedias, and it is logical because we are more numerous and we need the update is done to display teamroster perfectly. If we look forward, in 2017 we surely have an infobox for cyclists. I know it is already a wish from a part of our users. So we can imagine in 2018 a half of cyclist in activity will have their new infobox where datas are filled by Wikidata. But the idea of a bot become very interesting and usefull for classifications. Currently, we only go until the tenth when there is an interest to continue a little the classification. Each year we have around 600 races (including stages of the three grands tours), having a bot that is able to make classification will be a big progress. First for the biggest races, because for race 2.2 and 1.2 it needs again work to have one item by cyclist. Jérémy-Günther-Heinz Jähnick (talk) 18:17, 4 January 2017 (UTC)

I think I have fixed foWiki. The diff is [3]. It seems the wikimedia function for formatting numbers has an error for foWiki, therefore I have formatted that by hand now. About stages. I have added at line 3,424 in function stageLink the data for foWiki. The code in this function has data for frWiki and (deWiki, daWiki and foWiki). In all the other Wikis only the number is printed without the word "stage". That is something I have forgotten to code. I can look into the wikipedias to see if it is "7 stage" or "7. stage" in a wikipedia. If everything is all right now (stageinfobox and infobox) with foWiki the two edits can be moved to WDWiki. 3) About bots: Do you mean with "classification data" moving them from Wikipedia to wikidata or from an external Website (e.g. cqranking.com) to Wikidata? The later is more difficult to code, but something I would like to try to code someday. --Molarus 12:46, 5 January 2017 (UTC)

I have seen a sideeffect of the changes about "stage". Most wikis show in the first column of table listofstages only a number. With the new code this would change into "7 stage" or "7. stage", like in frwiki. I don´t think this is a problem. I have moved the fix from fowiki to WDwiki and I have changed the name for "Kingdom of Netherlands" to "Netherlands" in fowiki in the lang Module.

I have adapted the code for some wikis, not for all, and I´m sure some are not 100% right. For example cawiki and eswiki got new code. It seems in caWiki they write 3a while in esWiki they write 3^a. I have moved lbwiki to frwiki and nowiki to dewiki. Most wikis seems to write stage with a small first letter, but not all. That is all done in function stageLink. In the future, more adaptions will be needed for this function.

--Molarus 15:29, 8 January 2017 (UTC)

Sorry for the late. Yes, we have differences between catalan and spanish. I can notify @Herodotptlomeu: to ask him if the display is perfect in its language compared to FR Wiki. I try to do this for different Wikipedias, but I often have a problem of time to do this for everybody (I spend hours on my bike in this moment). About HU Wiki, on hu:Alberto Contador we have 1982. december 6., so year point space month day point, other example on hu:Team Cannondale–Drapac. Can you modify the module to adapt the format date for long version. For short version it works. I plan to bring help at this user to update their Wikipedia, they will start 2017 with a good base. I see their article hu:2016-os Tour de France. Jérémy-Günther-Heinz Jähnick (talk) 10:50, 12 January 2017 (UTC)

For me, it is no problem to get an answer a few days later. I have not moved the fixed code to all the wikipedias (If I do not write here, that I have moved code to local wikipedia, I have not). About huwiki, I will look into this. --Molarus 12:58, 12 January 2017 (UTC)

Thank you. Hejsa from DA Wiki explain me we have now a little bug about the word prologue in listofstages. Jérémy-Günther-Heinz Jähnick (talk) 16:48, 12 January 2017 (UTC)

That is fixed now, but that was an error in all Wikipedias that got the version with the "fix" (12:58, 12. January) for foWiki. Therefore I have updated WDwiki, daWiki, foWiki, cawiki, nowiki. I can´t edit esWiki, please, could you change that? --Molarus 10:48, 13 January 2017 (UTC)

Done for ES Wiki. Can you make the adaptation for HU WIki, I ride bike now, but I will finish in less than four hour, and I think I will take time to update rosters of HU Wiki. Jérémy-Günther-Heinz Jähnick (talk) 12:15, 13 January 2017 (UTC)

In the infobox now it says "102-ik Tour de France" as in hu:2015-ös Tour de France, see hu:Szerkesztő:Molarus, and hu:Sablon:Cycling race/teamroster is fixed too. This is done in function func_date, therefore table stageinfobox should be OK too. Code is at huWiki and WDwiki. --Molarus 13:50, 13 January 2017 (UTC)

Thank you. Finally, the Tour Down Under approach, I think we will start the function pointsclassification even if we have not for the moment the property (we will use PXXXX for few days). I think at this function and I start after a new section. Jérémy-Günther-Heinz Jähnick (talk) 18:10, 15 January 2017 (UTC)

Hey @Jérémy-Günther-Heinz Jähnick: Sorry, I don't understand you about of format dates in hungarian. Please give me a example. Now, the correct translate in spanish to One Stage is: Primera Etapa. Now, a half stage is: mitad de la etapa. hope I've helped you. Finally, What happened with Baremo of UCI Points in the races? I'm waiting for this new properties with great illusion. Kindest Regards. Douglasfugazi (talk)

@Douglasfugazi: ah, it was difficult to explain in english. In France, we write 8^e étape, 1^re étape and 3^e a étape. I ask because with es:Tour de Francia 2012 I have an idea (8.ª, 1.ª and 3.ª a), but I prefer being sure.

For UCI Points, it will not be a property because we always know the category, the circuit and the date of the race. I just need users add more informations on fr:Discussion modèle:Barème des points UCI : 2017, but also former attribution of points. If we have had UCI points in the 1990's, it is time to encode these datas. Jérémy-Günther-Heinz Jähnick (talk) 19:56, 4 January 2017 (UTC)

Hey @Jérémy-Günther-Heinz Jähnick: yes, it's correct 1.ª 2.ª 3.ª 4.ª 5.ª, etc. Kindest Regards. Douglasfugazi (talk)

Names of the teams

Hello, I hope all of you have a great holidays :) Because of my personal obligations and other projects that I worked on Macedonian Wikipedia, I missed some of new features in this great module, that I`m very greatful to @Jérémy-Günther-Heinz Jähnick: and @Molarus:. I started from 1.1. to create new templates, updating articles across my home Wiki, and also starting new season I start to write an articles about new editions of the races. I started to use every single template, and I`m very very happy about teamroster, that help a lot these days and it is great that even with cyrilic letters it is completely sort out. Again thank you Molarus :) I have just one little question: in template listofteams and generally all the names of the teams are written with their English names, even I have some translations on Macedonian with cyrilic again. If that can be change somewhat, or not? --Ehrlich91 (talk) 21:03, 6 January 2017 (UTC)

I have not thought about that while coding that function, sorry. Those translations will not be sorted. There is something I have to fix first for the new function stageinfobox. I guess, I will look into the problem next week, but I do not know if that is a small or a big problem. --Molarus 07:44, 7 January 2017 (UTC)

Hi @Ehrlich91: and happy new year. First I update the module with your translations, second I give you documentation for four functions. You can improve them if you want.

For your problem, we already have the same for LV Wiki and JA Wiki, and we will encounter it for greek and chinese. The solution is easy, we just need the creation of a new property for transliteration similar at ISO 9:1995 (P2183) and Revised Hepburn romanization (P2125) that translitterate latin in macedonian (only in this sense). With a such property, you will fill items days after days and using it as qualifier for each value of official name (P1448). On our side, we will can define if your property is used as a qualifier, so we take this value, if not we take the latin value. It is not so different as we do for media legend (P2096) for legend of photos of podiums or for description of jerseys. You should ask the question to the project chat to know if this norm of translitteration have a name. If we don't have properties (it is not impossible I miss a property, we have more than 3000) you will can launch a proposal and give our the link. Then I will can take contact with our users to explain our approach, and why it is necessary to adapt the module to non-Latin languages. I will take contact on your talk page in around one hour about translations. I don't work today (contrary to the three previous days). Jérémy-Günther-Heinz Jähnick (talk) 11:26, 7 January 2017 (UTC)

I have looked into the code. The reason why there is no translation is that I´m using the "official name" (P1448), but actual it is not necessary to do so. I could use the label instead, which is for example "Етикс-Квик Степ 2016" (Etixx-Quick Step 2016). A problem might be that I can´t delete the year for some labels. For example "Sky 2016" is written in Japanese "チーム・スカイ", which looks pretty similar to "Sky" "チームスカイ", only the point is missing. OK, I will try to add new code into the function to show for some wikis the label. --Molarus 18:42, 9 January 2017 (UTC)

No, the solution is not good : if the team change its name during the season, we will not have the change. The only solution is to have the necessary properties to do translitterations. This way, the value is a qualifier of statements for official name, if we add a new official name, the japanese users will see in his article latin letters, and will go on Wikidata to add a new value. Idem for greeks, latvians or macedonians. Jérémy-Günther-Heinz Jähnick (talk) 18:54, 9 January 2017 (UTC)

OK, I will not code this. --Molarus 22:01, 9 January 2017 (UTC)

I open a discussion about translitteration. Jérémy-Günther-Heinz Jähnick (talk) 10:26, 12 January 2017 (UTC)

As an example, I will take Q688762. This team has 5 official names and each name would get several translations. Why not take a property of the type monolinual text, like official name, as additional qualifier? Maybe P2561 (name)? This way, someone could for example add ...(zh) or ...(mk) or ...(jp). If the local wiki is zhwiki, the code would look if there is a value for zhwiki, if not, the standard value would be printed. --Molarus 12:48, 12 January 2017 (UTC)

Because the translitteration is already given as a qualifier, and we can't have the qualifier of a qualifier unfortunately. An other reason is the system must work in different domains. But thanks to Pasleim I read the documentation of transliteration or transcription (P2440), I found ISO 9 (Q913336). I continue and I found en:List of ISO romanizations... but I want the contrary. Norms to transform latin in macedonian. I continue to search. Jérémy-Günther-Heinz Jähnick (talk) 16:44, 12 January 2017 (UTC)

I don´t understand. I have done that for two mk-names and ja-names at Q645032 (Quick-Step Floors). The translations are from the infobox of the mk and ja articles (we could move the translations per bot). I hope this additional data creates no problem in our tables. There is another advantage: If there is for example, a japanese cycling team with an official name written in japanese, we could add the latin name as qualifier. This way our module would be really global. --Molarus 10:10, 13 January 2017 (UTC)

@Papuass, Ehrlich91, Aps-vologda, K-iczn:, you make translitteration in your languages respectively in latvian, macedonian, russian and japanese. For the romanization (from you language to classic latin alphabet), we have ISO norms listed in en:List of ISO romanizations. Have you ISO norms that permit to make a translitteration from latin into your language ? If no, how you do ? How you call that ? I am a little lost in this domain, that is why I ask your opinion. A topic was open on the project chat, and Pasleim explain me we already have properties such pinyin transliteration (P1721), McCune-Reischauer romanization (P1942), revised romanization (P2001), Revised Hepburn romanization (P2125), Georgian national system of romanization (P2126), Hungarian-style transcription (P2719). Jérémy-Günther-Heinz Jähnick (talk) 17:34, 12 January 2017 (UTC)

@Ehrlich91, Papuass: I have read the mk text of Q847200 (Katusha), see Module talk:Version 2. It works! I thought about adding in the lang module "function lang_priority () return {'mk', 'ru'} end" if the wiki wants to use the "official name" - qualifiers. First priority is 'mk', second priority is 'ru'. Latvian Wiki would just have 'lv' in that function. If there is no such "official name" the standard "official name" is printed. Without that function the "official name" - qualifiers are ignored. It is a simple way to add the language preferences without the necessity to edit the code in the Cycling race module. Since all this is done in the function that reads the "official name", all team names in all tables should behave in this way. The job will be done next week. Any suggestions? PS: I know mkWiki don´t have the lang module. That module is new, it is used in some wikis for showing country names in the classification tables. Without that, no country names are shown. This is the solution to speed up the classification tables. --Molarus 10:03, 11 February 2017 (UTC)

@Molarus: Thank you Molarus for finding solution for this :) I can see that it works. If you can point me out what is actually "lang module", I can implement in our Wiki. Thanks again --Ehrlich91 (talk) 15:29, 11 February 2017 (UTC)

I have to test the code a few days more and maybe I have to change the code if there are wikis who have the code for the "official name" but not for country names. For developing the code I´m using the lang module at WDwiki, but it has a false name: Module:Cycling race-WD. It will be mk:Модул:Cycling race/lang at your wiki. The right name could be seen if you are opening an article with the cycling module in edit mode and look at the bottom of the page. You will see there is a list of used templates and modules. The "red" module is the lang module. At the moment, for example, frWiki and daWiki are using the lang module, but I guess, they will not have the code for translating team names. DaWiki is not printing the country column, it is switched off in the lua module. The data in the lang module is used at daWiki only for the names of national teams. This way, for some articles, lots of lua time is spared.

DeWiki don´t want to print "Sky" but "Team Sky", which is at the moment not possible. This new feature could be used to localize team names, even for latin script Wikipedias. Therefore, I guess, in the end most wikis will use this feature, but most of the time without finding a local translation. PS: I think this feature is worth to be published at Wikidata:Status updates. This way, we would be the second time in the Wikidata newsletter (first time was because of the infobox). --Molarus 16:31, 11 February 2017 (UTC)

MkWiki has a first version, see mk:Корисник:Molarus (Katusha and Katusha - Alpechin are translated), but the code don´t work where the data is coming from a season article (e.g. Kathusha 2016) and not from the team article (Katusha). I have to go from the season article to the team article when possible, to get the translations. It seems teamtimetrialclassification has this problem too. --Molarus 19:00, 13 February 2017 (UTC)

The second part is at mkWiki. The new code is so far not approved, but it looks good in preview mode. If everything is all right, I will test the code in other wikis (nothing should happen, since they do not have any data in their lang module) and insert the new code at WDwiki. Maybe next job is the victory table? --Molarus 16:30, 15 February 2017 (UTC)

Code is at mkWiki, WDwiki, frWiki and deWiki. On this page the lang module looks like this: Module:Cycling race-WD. That means: First Japanese, then Macedonian and Russian and at last the standard team names (in latin script). --Molarus 17:59, 16 February 2017 (UTC)

pointsclassification

This function will be very similar at generalclassification, except the fact we don't take time, but points for (P1358) for each cyclist. When we make a statement for points, there is no unity. The other difference will be for jersey, with another item and other jerseys. I will take the time to adapt this part of the code. We have the chance that once this function will be OK, some others will be very similar, so we will can create more function this month. Jérémy-Günther-Heinz Jähnick (talk) 19:05, 15 January 2017 (UTC)

Something like fr:Tour_de_France_2015#Classement_par_points? Is there a property for pointsclassification? By the way, maybe we should have the option to create an item for all clasifications with the properties P2501 (results) and P2502 (classification of). --Molarus 15:11, 16 January 2017 (UTC)

Normaly, we should have this property in few time : Wikidata:Property proposal/Event. it seems we no longer have obstacles. results (P2501) and classification of race (P2502) will be used for UCI classifications (nation, cyclist, country) and for hot points of big races. It is more easy for translations to have specific items for the classifications we often see on stage races.

Yes, like fr:Tour_de_France_2015#Classement_par_points Jérémy-Günther-Heinz Jähnick (talk) 10:14, 17 January 2017 (UTC)

We have the property : points classification (P3494). Jérémy-Günther-Heinz Jähnick (talk) 09:56, 18 January 2017 (UTC)

OK, I will start with coding. --Molarus 11:54, 18 January 2017 (UTC)

I finish to fill 2016 Tour de France (Q18574623), it is a good example tranks to the presence of different jerseys. Jérémy-Günther-Heinz Jähnick (talk) 12:03, 18 January 2017 (UTC)

			if content.jerseyIDs[i][num] == "Q24645209" then bg_color="#90EE90" break end -- Jersey green.svg	
			if content.jerseyIDs[i][num] == "Q27114205" then bg_color="#808080" break end -- Jersey black.svg
			if content.jerseyIDs[i][num] == "Q25831179" then bg_color="#FFFFFF" break end -- Jersey white.svg
			if content.jerseyIDs[i][num] == "Q26919974" then bg_color="#FF8666" break end -- Jersey red.svg
			if content.jerseyIDs[i][num] == "Q24687409" then bg_color="#99CBFF" break end -- Jersey blue.svg
			if content.jerseyIDs[i][num] == "Q25265938" then bg_color="#BF80FF" break end -- Jersey violet.svg

About jerseys, we will continue to associate the same colours of jerseys to the same colours of background for the winner of this classification. So I adapt the code of generalclassification to this classification and add two new colours, black and green. If on a race we discover they use another colour of jersey, I will create the item, put it on the kit, and add a new line in the code. Jérémy-Günther-Heinz Jähnick (talk) 13:51, 18 January 2017 (UTC)

I´m trying to code the classification tables in a new way. In Module:Version 2 there is the new function new_classification, that gets data from functions like pointsclassification, stageclassification or teamtimetrialclassification. This data tells the function for example the way the table should look. I have developed this for function stageinfobox. The advantage will be, that coding a new classification table will be just writing a different set of data. Since stageinfobox has only 0,5 s lua time, while infobox has 1,0 s lua time, I hope, the classification tables will be faster too. I will still use functions like jersey, number and unit, therefore I don´t have to code them again. If I reach that goal, maybe more functions could be coded this way. PS: I have seen that the item "Tour de France 2016" has more new properties. --Molarus 02:23, 23 January 2017 (UTC)

Yes, I forget to say you we have now teams classification by points (P3496) and teams classification by time (P3497). I hope I will have the time tomorrow to look all with more details (with this rythm, I will finish to be employed by a team...). Jérémy-Günther-Heinz Jähnick (talk) 19:29, 23 January 2017 (UTC)

We also have to think about 500 "expensive function" limitation. 6 stage race Tour Down Under has 428/500. I think with Paris-Nice (8 stages) we will be over that. Are there things that can be cached on page level for all modules (I guess not)? --Papuass (talk) 09:41, 24 January 2017 (UTC)

Part of the problem is that I do not know what an expensive lua function is. For example fr:Modèle:Cycling race/stageclassification has 23. --Molarus 17:51, 24 January 2017 (UTC)

Getting new Wikidata item certainly is expensive call. I would guess that getting property of that item is not. It means we are getting 428 items (riders, teams, countries, stages) --Papuass (talk) 19:48, 24 January 2017 (UTC)

I hope this limit will no longer exists, but each time I propose something it is like I speak to a wall... Jérémy-Günther-Heinz Jähnick (talk) 19:50, 24 January 2017 (UTC)

I have done some tests, the expensive lua function is "mw.wikibase.getEntity" (for Wikidata items). Another expensive function is used for the rider names to check if I should write the rider name as a red link or a text, if there is no local article. At the moment, that is done only at enWiki, frWiki and deWiki. Therefore each 10 row table has about ~25/35 expensive lua functions. Additionally there are the expensive lua functions in the other tables, like infoboxes and stageinfoboxes. I have cached the flags, but that is only possible per table. Therefore reducing the number by maybe another table is possible, I think. We would save most, by giving the editors the option in the article to switch off the team data. But I guess, they would prefer to use templates instead, which do not have that limitation. --Molarus 20:29, 24 January 2017 (UTC)

1) I have fixed a big time problem. The function that works with national teams had used the item of countries like France (Q142) to build something like "France espoirs". Now I have changed the code to use the new language module to get the name of the country and the lua time for 6 tables went from ~3 sec to ~1 sec. In frWiki no table should use for example the item for France Q142 anymore, because this is to time consuming. Those wikis that do not have the new lang module, will get a problem when printing something like "France espoirs".

2) Now, all classification tables show only "blue" wikilinks or black text, no "red" links and therefore each table has only ~25 expensive lua functions. 10 expensive lua functions less per table is better then "red" wikilink, I guess. Therefore 6 tables a 10 rows have 130 out of 500 expensive lua functions. I guess, this problem is fixed too.

3) Missing is still the code for the time, points, jerseys. I guess I can do this next week. --Molarus 12:31, 27 January 2017 (UTC)

I will now add the two other new classification tables into the code and it seems, I have to do some small adaptions in the code to print the time and the points. Everything else worked well, see Module talk:Version 2. Since both tables look similar to "teamtimetrialclassification", the functions will be called "teambytimeclassification" and "teambypointsclassification". Is that OK? The heading will be in both cases "Classement par équipes".

I think, the new code for the classification tables is done (no testing so far), except the line brake after the table is missing (printing two tables next to each other, not below each other). Maybe some thinking should go into that problem, for example, why not do this by modifying the behavior by adding some data in the article into the table? Maybe something like "<br>" or "tag=<br>" or "code = <br>". Are there more possible options of data to insert into those tables? We should be careful with that, because this will be used often, therefore changing that later, will be a lot of work. Of cause I could do that the same way as the old classification tables worked, that would be work of two minutes, just copy and paste. Maybe you have some experience with that? Would that feature be useful? What about the two new team classification tables. Should they be printed next to each other or below each other? And there are no order, therefore which team table would be printed first? --Molarus 00:47, 6 February 2017 (UTC)

The two new functions are working too, time for coding was less than an hour. "line break" works too, see Module talk:Version 2. The commands for a second parameter are: "newline= false" and "newline = true" (space doesn´t matter). If you do not like them, I can change that. We could even think about translating that command. For example: a half translated command like "newline = oui" (frWiki) or a full translated command like "Zeilenumbruch = ja" (deWiki). Maybe we could do a standard command in english that works in all wikis and translated commands for those wikis who want that additional. I´m going to test the tables now. --Molarus 12:21, 7 February 2017 (UTC)

I think more at teamsclassificationbytime and teamsclassificationbypoints, I do searchs few day ago, and see that teams was used at the plural form, and time or points come to qualify the classification and not the team, even if English is see as bizarre for Frenchs. I think for the second table we should have Classement par équipes aux points. If teams classifications by time are natural, it is not the case for teams classifications by points.

On the second point, it is not necessary : users use Col-begin, Col-2 and Col-end because they can add text to give more details for a classification if the want to develop the article. For the time being, it's rare that contributors develop the text of articles, but I think it will happen very regularly when we have centralized even more data. For the display of a big number of tables, we have an example on fr:Tour d'Italie 2016. Your option can be interesting for stageclassification : when it is the last stage, we must use a template (Absatz or Clr) different according Wikipedias, so we can imagine a parameter as laststage=X to apply just at the last stage. Here, X means yes and can be compared to a tick. In a similar way we could apply to teamtimetrialclassification that can be a last stage. This way, we can always had the X that can be understand by other languages, and last stage because they already know the word stage by the name of functions. Jérémy-Günther-Heinz Jähnick (talk) 12:33, 7 February 2017 (UTC)

1) Function names are changed. 2) I have added a new translation, but in most wikis it is the same as for "Classement par équipes" (better then a wrong translation). 3) I have remembered that the "new line" problem must work for the already deployed classification tables as before or we would destroy lots of article layouts. Therefore the two stage tables must work as standard as before. We will have in the future articles that will print tables like "Classement du meilleur jeune" and "Classement par équipes aux temps" next to each other. FrWiki is able to make a section for each table next to each other, but most wikis don´t do it this way. They add templates for this. Something like laststage=X would have the false name for these cases. Now I guess, no one will ever use "newline= false", they will use templates instead, therefore it is not necessary to put much effort into this. But I think it is nice feature and I will keep it. I will write a short documentation into the code as for the other such goodies. 4) I will start testing tomorrow. 5) By the way, I would prefer to do next the "Names of the teams" problem. I have thought about that and if I´m right, I only have to modify function timeStartEnd. I would insert also code to tell the module the preferred language of a wiki. Maybe that could be done in the lang module (function language_priority () return {'mk', 'ru'} end). For example, mkWiki would prefer cyrillic text over latin script text, while enWiki would show nonlatin text at last. Similar problem for greek, japanese, arabic, chinese, ... If I´m right, that problem could be done in a week. --Molarus 14:46, 7 February 2017 (UTC)

fr:Tour d'Italie féminin 2016 is an example for an article where it would be nice to switch the country column in the article off. I have insert that into the code. With "country = false" or "country = true" editors could add or delete the country column. --Molarus 15:39, 8 February 2017 (UTC)

Done, the code is at WDwiki and frWiki. --Molarus 12:46, 11 February 2017 (UTC)

Hi Molarus, I see we lost the ^r when a cyclist finishes first, ^1er, see fr:Modèle:Cycling race/generalclassification. No other problem, I will have more time in two weeks. Jérémy-Günther-Heinz Jähnick (talk) 17:51, 16 February 2017 (UTC)

Fixed in WDwiki and frWiki. --Molarus 18:23, 16 February 2017 (UTC)

I spend time on the computer today. I make tests with teamsclassifications by points and by time, see at fr:Modèle:Cycling race. For a team that finish first, we write 1^re instead of 1^e, as we do for a women cyclist. I am interested if we can have the first line in bold. I see that finally we can have a jersey : yellow bib, teams classification (Q27644112). It don't produce an effect on the background. For a reason I can't explain, I see we have a problem with the time with the Vuelta. The other things work perfectly. Jérémy-Günther-Heinz Jähnick (talk) 13:24, 3 March 2017 (UTC)

That is maybe a week of work, especially the new features (jersey and background) will need some time. "Tour de France 2016" does not show the minute for team Trek-Segafredo. I guess it is zero. And "Tour d'Espagne 2016" has lots of false time data. Should I look into this now or after I have done the victory table? I think I should do at least the time error today. --Molarus 16:54, 3 March 2017 (UTC)

As you want. For teams, the presence of the jersey don't affect the background, this point is not urgent.

For the Tour d'Espagne 2016, I just see I use the bad property, so I bring the correction. Jérémy-Günther-Heinz Jähnick (talk) 18:02, 3 March 2017 (UTC)

No problem at all. The code was already there, just a few additional words here and there. I like it, if things go this smooth. The code is at frWiki and WDwiki. --Molarus 23:01, 3 March 2017 (UTC)

Arrivées and Départs

We could build the table "Arrivées and Départs" in the saison articles. --Molarus 17:38, 24 January 2017 (UTC)

It is possible, but I don't have ideas for specific cases for the moment. Jérémy-Günther-Heinz Jähnick (talk) 19:52, 24 January 2017 (UTC)

Bot maintaining tasks

We could collect possible bot maintaining tasks here, so I know what bot scripts to code.

• I have found at team Colpack 2000 (Q24134332) the rider Andrea Nencini (Q20985580) as team member. which is actually a volley ball player. The right item is Andrea Nencini (Q24135035). Checking the team members whether they are riders could be a job for a bot.
• Another job could be to move "official names" from the team item to the saison items.

--Molarus 16:06, 9 September 2016 (UTC)

The first one isn't for a bot, it's for SPARQL. --Edgars2007 (talk) 16:17, 9 September 2016 (UTC)

In my view, it could be done both ways. I would code a pywikibot script using a simple sparql-query, while for the other way a difficult sparql-query is needed. By the way, I have already written a sparql/pywikibot combination. The result is a list of wikipedia articles (see de:Benutzer:Molarus), which I´m looking into to find false wikilinks for riders. I have already used such a list to fix some problems at enWiki and after I´m done with deWiki I will create such a list for frWiki too. I will see if I can manage this without speaking french. --Molarus 20:03, 9 September 2016 (UTC)

Here is a simple SPARQL query to list riders, which doesn't have P106=(any subclass of) Q2309784. And here is another simple query for stats of all P106 values. --Edgars2007 (talk) 20:22, 9 September 2016 (UTC)

Thanks. I have tried to understand why the first query shows more false occupations than the second query, I do not understand. And I can not rewrite the second query, I have tried. The problem is, those queries are still to difficult for me. --Molarus 21:21, 9 September 2016 (UTC)

This is the code to get someone who is a rider and has the occupation speedskater. One example is Q241961 (Ellen van Dijk), who should do both. The question is: Is that true? At least this way it is possible to check that by hand (typing into the code the next occupation to check) --Molarus 21:37, 9 September 2016 (UTC)

graph-Extension

Last night I have played a bit with the graph-Extension. The result can been seen at User:Molarus/graph. The first picture with the two lines is from me, the second is an example from the documentation. I have moved the code into a lua module and the result can be seen at Module talk:Version 2 (the line). Wikipedia is using this already, see fr:Module:Graph and where it is used. This extension is about building a png-file out of data - Wikidata. On WDwiki this extension is combined with SPARQL, for example User:Smalyshev (WMF)/Test2. I think the second example on my page is interesting, because this way we could show some cycling data. I think this picture is only created new after editing an article, not like Wikidata that updates itself. I have found an tutorial: here. At the moment, I see this as an experience, I´m sure there is a reason why no one else has combined Wikidata, Lua and graph before. --Molarus 12:31, 4 October 2016 (UTC)

I have an idea for an use case: mountains. Do you remember the pictures of the mountains at the Tour de France - website?

We could say:

Cycling race/mountains|Q123|Q456|Q789

We will get a picture with a en:Slider (computing) to slide over the three mountains. I don´t know if we already have properties to add the data to the mountain items. I have found the website http://www.cyclingcols.com/ while I was writing articles for the TdF 2016. We have to add a references to the data in WDwiki too and somehow show the ref in the article. I will not start with that tomorrow, because I still have to learn writing code for graph, but I will put that on my todo-list. I see as advantage that we don´t have something like that for our articles. And drawing pictures is a lot of work. This way, I would be just adding some data to WDwiki and the lua module does everything else. Another advantage is that we have to read only the items for the mountains - very fast - therefore the creation of the picture is the most time consuming thing. I don´t know if the 10 seconds lua limit will be a problem, but we do not have to show 50 mountains in the picture. --Molarus 15:10, 4 October 2016 (UTC)

I have seen an infobox about mountains for riders at de:Mont_Ventoux#Radsport, the french version is fr:Cyclisme au mont Ventoux. Maybe we could use as property P2198 (average gradient) and P2595 (maximum gradient). --Molarus 02:41, 4 January 2017 (UTC)

victories

Since few months, we have victory (P2522) that is able to list victories of team, as we have for Verandas Willems 2016 (Q22062004). teamroster was our better success, and I think it will be similar for victories. I don't work IRL from the 15 to the 30 november, but I already write ideas about this future function here.

• For one-day-races or stages, we always know the point in time (P585). As seen on listofstages, we are able to write it without the year. We are also able to make a sort with dates. Jérémy-Günther-Heinz Jähnick (talk) 19:05, 11 November 2016 (UTC)
• If the race is a single-day-race, we just have to write the name of the race in the column Course. If the cyclist win a stage, we will know it is a stage, so we will can write the stage, a comma, and the name of the race. If the cyclist win a stage race, we will can display just before general classification (Q691836) or directly have translations.
• For the country, it is very easy because we have this information thanks to country (P17). The question will come when a race is in two countries or more.
• The class is know thanks to instance of (P31). We can make a link to the first value of part of (P361).
• The winner is very easy, we know him via winner (P1346) and the qualifier stage winner (Q20882747) if it is a stage or overall winner general classification (Q20882667) if it is a race.

This project of function is interesting for users because the will only need to add a value for victory (P2522). Other information will be know because they are used by other functions. Jérémy-Günther-Heinz Jähnick (talk) 19:43, 11 November 2016 (UTC)

We will need a sorting function. Because it is not practical to have to type everything in chronological order. What about montain bike, track... victories? How will the function differentiate? Personally, I think this function is interesting, but not to prioritize. It will take in everycase a very long time until all races and stages are in wikidata. As the new year is close, I would prefer to have the infobox for racer ready (so no more "current team" update to do everywhere). Information is already in wikidata for this case. Psemdel (talk) 10:11, 20 November 2016 (UTC)

Yes for a sorting function, depending the class of the race, but also its name or the name of the cyclist. I think it is not very complex. And we have these informations, but I am a little annoyed for before 2005 because I have not enough datas about class of races. Some Wikipedias have an article about cycling race class defined by the International Cycling Union (Q22348500), but no informations about the past. For the type of victory, it is easy and we have predicted it since months : when you add sport (P641) road bicycle racing (Q3609), you add in your infobox a little logo of bike. if there is no statement, there is no logo, so the statement is in reality compulsory. The real utility of this statement was for permitting the algorithm to recognize a cycling race on road for this function. For cyclo-cross, we can imagine another function, even if we don't have for the moment articles about these races. Thanks to this statement, we can select a victory only if it concern the road cycling and exclude other victories. (I continue after) Jérémy-Günther-Heinz Jähnick (talk) 11:27, 20 November 2016 (UTC)

The new cycling season will start in a few time now, and it takes always time to get all the translations (and I ask to get translators on meta, silence radio... trist for a such project). We have a big part of articles about UCI race and I think 2017 will see all these articles for some Wikipedias (I think at FR Wiki where we are numerous, but also at DA Wiki where an user do a very good job of translation). The idea is to permit users to create articles about seasons, and we need victories. For the cyclist infobox, the idea is good, but on FR Wiki we have again a hand of users that will again make loose our time, I remember in august 2015 when we adapt the infobox for Wikidata and mid-september 2016 when a well know user and his friend decide to delete/neutralize the function to display family saying "there is no consensus" when this function was here since the adaptation of the infobox with Wikidata... So I guess if we do this infobox now, even if thanks to the Prise de décision we don't need to take the opinion of these FR Wiki users, we will again have these users on the back, even if everything works perfectly ("Wikidata is the devil"...). I add that all is far to be perfect on this side. Even if we can define the current team, we are not able to display all the former teams : in some case, even if it become rare, we haven't the official name of teams. On other case, it lacks all the previous teams, and even items for some of them or clubs. Sometimes, there is a problem on Wikidata, see the team Peugeot and Z where nobody is agree, or Bianchi. And the worst is we don't have written if a cyclist is an amateur in its team. We also have the case of the team Armée de Terre which become continental and where cyclist became pro where they were previously amateurs in their team. The idea I propose is to write a patch and give it to our contacts to adapt their infobox during few months. This patch will permit to display the current team and nothing else, this way users will save a little time. For me, this infobox will be the more complex to build, it is my opinion. I also guess we will hear : "and if the user prefer directly write the teams on Wikipedia". Don't forget an user, alway the same, makes problems with teamroster last week. Again a time he is alone in its battle but never stops. Jérémy-Günther-Heinz Jähnick (talk) 12:20, 20 November 2016 (UTC)

Another thing that would be nice and not too long, would be to adapt "Infobox Compétition sportive" (infobox for races), in order to get automatically the country, the last winner, the winner with most victories... Psemdel (talk) 17:03, 20 November 2016 (UTC)

Yes and no. It suppose we have all the datas on Wikidata for the winner with the most victories. For the country it is easy and for the last winner, it suppose we have in has part(s) (P527) all the editions of the race. It is the case for the youngest races, but not again for others. I will say on the technically point, it is not so difficult. The problem again a time is human : see here. At the end of june 2015, I ask to use three properties, the date of creation, the date of dissolution and the sport. The admin Supertoff was responsible of a loss of time, and I get these three properties only at the beginning of february 2016, seven month later. So I prefer working to create new functions we can give to a maximum of Wikipedias instead loosing my time on FR Wikipedia. The fact is it is more easy to give a new function that improve an existing template. It is one of the reason that explain the Projet:Wikidata was "killed". Jérémy-Günther-Heinz Jähnick (talk) 18:21, 20 November 2016 (UTC)

You say for the youngest races, but if you can use Cycling race/listofwinners, you have already the whole list of winners. It is not really an issue. The point is only: I update wikidata to have the listofwinners updated. But still, I have to go in each Wikipedia to adapt the "last winner". That is really a waste of time. Psemdel (talk) 12:05, 27 November 2016 (UTC)

I have started by listing all the races of "Verandas Willems 2016" (Q22062004) at Module talk:Version 2. Next step is sorting the races after time, course and class? Maybe I will start with sorting after time and improve the sorting while adding the other data. A more difficult problem will be building a good course column, because we can´t take the label for that. Point 2 says that there are three winning possibilities: One day race, a stage and a stage race. And it is not always: stage, a comma, and the name of the race, for winning a stage. In german, they put the stage data as last information. And "1re étape" must be translated for each wiki. For the country we will take the lang module and if there is no lang module only a flag will be shown. This way, the lua time will be shorter.

Maybe it would be nice to have the option to tell the table in the article to display only certain victories. As options, I could think about certain classes, certain raiders, only stage races or only one day races. At deWiki, they add at the stage articles victory tables depending on "UCI WorldTour 2016", "UCI Europe Tour 2016", ... and they have victory tables like de:UCI Europe Tour 2016. I don´t think they will substitute their tables by this table. I see rather the use of this table by more unknown teams and older seasons. I don´t know what makes sense, but I think this way we could make more out the list of victories. We would need a good way to tell the table what to do. --Molarus 22:24, 17 February 2017 (UTC)

I have developed a new feature, see Module talk:Version 2. There is a small warning sign in the table header and the warning message is the tooltip. At the moment the warning is always on, later, this warning sign will be shown only when an error occurs. The warning messages are translatable and they could be used in other tables too. We could have this feature for all wikis or editors could switch that feature on in the lang module. It that is OK, I would add more error messages. Comments?

Now, class="wikitable sortable" is in the table, but I have to add additional data to tell the sorting code how to sort right. I will need some time to understand that template (in frWiki, it is Modèle:Sortname). Lets see if this is a better alternative then coding a sorting algorithm myself. --Molarus 02:30, 19 February 2017 (UTC)

I´m writing the code for sorting the date and I have found some problems, where I would like to get some help. My solution is to build a sortkey consisting from: year month day. I have found two problems: 1 ) What is the right sortkey for a multi day race? The startday or the endday? 2 ) If I have as date only the year or a year and a month, what is the right sortday? At the moment my solution for both questions is: startday and for both cases the 31 December. At Module_talk:Version_2 you can see both problems. I´m printing the year as date for the two races with problem 2. By the way, I have switched off the sorting for the races column.

Next step is building a nice race name. --Molarus 01:52, 28 February 2017 (UTC)

As predicted, I come back for a few weeks. Since the beginning of January I traveled about 2500 kilometers by bike in my constituency to distribute leaflets to prepare the legislative elections. My commitment ended yesterday, I think to take a new, surely beginning in April. I will take this day to read all I must know. Jérémy-Günther-Heinz Jähnick (talk) 10:10, 1 March 2017 (UTC)

Hi. Nice, you are back. Nothing important has happened here. Maybe, this is a good news. There was one thing: I have written a note to editors at jaWiki and arWiki about the new feature of displaying team names in non-latin script. I got no reaction from jaWiki, while Mr. Ibrahem said the code works fine for arWiki. --Molarus 11:15, 1 March 2017 (UTC)

I have worked at printing the right name of a stage victory. Code for that is at line 170 - 183. I´m getting the word "stage" and its translations from Q18131152. At the moment, I have the code for the stage victories for en, fr, de and other wikis. I have to look tomorrow how the other wikis write that information and this way more wikis do not have to print the fall back version. There is the possibility that we do not have the number of the stage in the item. I´m testing this by asking WD for 'P1545x'. In this case I will print a question mark and write, for example, in french ?^e étape. Is that OK? PS: I have just remembered that there could be a stage zero, a prologe. So I have looked into our module and maybe I should take the translations from function func_prologue and stageLink? Or maybe both? If there is no translation in the code, look into WD? OK, I will find an answer for that tomorrow or the day after.--Molarus 01:41, 2 March 2017 (UTC)

Ok, so I take my time to read and understand. For a multi day race, we take the end time (P582) because the final general classification occures the last day. It is the same day of the last stage, and a cyclist can win the last stage and the final general classification, it makes two victories. Interesting the option that permits to dispatch the victories according the circuit thanks to P361, as Germans do. If we have no dates, it is not normal, the information should exist, so I propose the consider the race occures at the end of the year. With Verandas Willems 2016, we have an interesting case because we don't have add informations for all races.

Yes for the word stage. Normally, we always have a statement for the number of the stage because it is compulsory for listofstages. Jérémy-Günther-Heinz Jähnick (talk) 16:49, 3 March 2017 (UTC)

Maybe there should be the possibility to use this table not only in season articles, but in team articles too. This way, the small wikis could use this table too, since they do not have season articles. This could be done by using the "has part" (P527) properties. Maybe we should allow the victory property in team items too or rather we should assume that some editors will use the victory property this way too. There is one problem: Season articles have the "has part" property too, but they list riders. Therefore we have to be sure it is no list of riders, which could be done by looking for a P31:human. --Molarus 16:54, 3 March 2017 (UTC)

Tomorrow, I will start testing the table (as it is now). I have seen lots of season items with the victory property, therefore I have enough data for testing. --Molarus 21:56, 4 March 2017 (UTC)

The code for the victory table is at frWiki, see fr:Utilisateur:Molarus. I had to rewrite parts of the code, but I´m confident that the code is far better now. Still, I´m not 100% sure that there is no error anymore. Problem is, that the items could be in good and in bad condition and I have not tested all possible conditions. At the moment, the code is only at frWiki. If you want some changes, please tell me. --Molarus 06:09, 9 March 2017 (UTC)

I prepare the call on fr:Modèle:Cycling race/victories. Is it possible to rename the function in the code victories ? It is to make a parallel with listofteams or listofwinners. The result is very good. For the moment, it lacks the flag of the country of the cyclist, and a link to the item of the race, when we speak of a stage race. I see also more space between entries, as we have on FR Wiki fr:Saison 2017 de l'équipe cycliste Quick-Step Floors. I like space in articles.

On a second time, I am interested if we can test new things. For example, QST wins the Dubai Tour, in a interested if we can write just before general classification (Q691836). Fortunately we have an item. Then, it is just an idea and it is for French Wiki, the idea is to replace the comma in some cases. For example, 1^re étape, Tour Alsace will become 1^re étape du Tour Alsace. Du is the french for of the. If the algorithm recognize the item of the race start with Tour, it will know he must replace the comma by du. In the same order, I have in memory :

• des for Trois, Quatre, Boucles
• du for Triptyque, Tour, Grand Prix, Circuit, Mémorial, Trophée
• de la for Ronde, Semaine, 'Classica, Flèche, Course, Classique
• de l' for Étoile

For other races, we are not able to define what word will replace the comma, but it is not a problem. Another day, we will see for national championship. Jérémy-Günther-Heinz Jähnick (talk) 12:08, 9 March 2017 (UTC)

The first race in Module talk:Version 2 is Q28125545 (Contre-la-montre masculin aux championnats d'Australie de cyclisme sur route 2017) and I´m showing the official name (P1448) of the race, which is "Championnat d'Australie du contre-la-montre" in french. If there is no official name in the language of the wiki or in english or french, I show the label of the item. This is the solution I have found for the problem with the national championship.

The function is renamed and the rider got a flag in frWiki. I have seen in your examples, that some riders are season articles. I have not looked so far why this error. What do you mean with a link to the item of the race, when we speak of a stage race? Do you mean that for "2e étape, Tirreno–Adriatico" the "2e étape" should link to the article "2e étape, Tirreno–Adriatico" and "Tirreno–Adriatico" to the article "Tirreno–Adriatico"?

The space and a better french name for the races is for tomorrow. I think, I will work on the remaining problems in Module Version 2 and copy the fixes later to frWiki. --Molarus 00:36, 10 March 2017 (UTC)

I think more something like this. A link to the section of the stage of the article and for the race simply the link to the race 2017. This point has a problem on FR Wiki because a bot passed and modify the template, see here. By the past, we had {{2e}} étape, now it is {{2e|étape}}. This point is not very important.

For championships, I had another idea. If we put the official name in the item, we had to do the work each year, idem for translaters. So I think it would be better to write it in the item given for instance of (P31), Australia National Road Cycling Championships - Men ITT (Q22284183) for this case. This way, we have to do this for line race and time trial for around 150 countries, it is more easy if in more I create a kit to translate for this. Jérémy-Günther-Heinz Jähnick (talk) 10:13, 17 March 2017 (UTC)

Most of the new french race articles I have seen do not use the new system and therefore the wikilinks for those articles would not link to the right section. In the old system it is "Tirreno-Adriatico_2017#7e_.C3.A9tape" and in the new system it is "Paris-Nice_2017#7e.C2.A0.C3.A9tape". There is a nonbreaking space (& nbsp;) between 7e and étape in the new system.--Molarus 14:52, 18 March 2017 (UTC)

Yes, I remember an user do a big modification by bot few monthes ago, and discussions occured on the main space discussion of FR Wiki. I wasn't part of these discussions.

I see on the display of Module talk:Version 2 we have 3a^e étape des Trois Jours de La Panne instead of 3^e a étape des Trois Jours de La Panne. Jérémy-Günther-Heinz Jähnick (talk) 11:24, 20 March 2017 (UTC)

Thanks, I didn´t see this error.

This bot has created so many problems. Another one is fr:Trois_Jours_de_La_Panne_2016#3ea_.C3.A9tape versus fr:Tour_de_Grande-Bretagne_2016#7e.C2.A0.C3.A9tape_A. In the second example it is written 7e étape A. The result is that I do not know what Wikilink I should build to link to the section 7^ea étape and 7^eb étape. What a mess.

Next step is to fix the error, improve the french code for the prologue, optimize the whole code and adapt the improved code to all language versions.

--Molarus 13:49, 20 March 2017 (UTC)

Ok. I also have see a problem with Etixx-Quick Step 2016 on fr:Modèle:Cycling race/victories : I decide to do few weeks ago a test with a team with numerous wins, and discover races were not added. So I add them, but when the table is displayed, we have not by default a sort by the date, we have a sort by the order of statement on Wikidata. No problem for halves stages if you don't make a link, it is very rare we have this case. I see on FR Wiki on SEG Racing an user add manually the victory and doesn't see the change due to the modification of the template (and see that by mistake he writes Fabio Jacobsen as Danish where this cyclist comes from the Netherlands, a mistake due to the name, a problem that cannot occure with Wikidata). Jérémy-Günther-Heinz Jähnick (talk) 18:49, 21 March 2017 (UTC)

I have the code for sorting and I hope it is without an error. This is the algorithm: en:Insertion sort (my code is a bit changed). The code is simple and for sorted data there is almost no additional lua time necessary. frwiki is updated. --Molarus 22:43, 21 March 2017 (UTC)

Perfect. To continue with details, I would be interested if we can have a link to classes (1.UWT, 2.2...) to the first value of part of (P361), if we have a statement for this. Generally the link will be this year for UCI Europe Tour 2017. A sort is also needed to group possibly races by classes. On FR Wiki, we have something like span style="display:none with a number. Here, I don't know if it would be better to apply this solution or to apply another, because we are surely able to directly sort these classes.

For national championships, I have a doubt between official name (P1448) and name (P2561). I think more at the second solution. For an item as 2016 German National Time Trial Championships (Q27055558), we will never have articles, but we have an item for Germany National Road Cycling Championships - Men ITT (Q27055700) thanks to the instance of (P31), and this item have thanks to part of (P361) German National Road Race Championships (Q80798). This last item always have an article. The case is specific to the national championships. A national championship can be recognized with CN (Q22231119). By a little different way, we learn that the 2016 German National Road Cycling Championships (Q27055507) part of (P361) 2016 national road cycling championships (Q22021840). I will surely discuss with Anthony59999 to write a little documentation for championships, because even for me the subject is a little difficult. Jérémy-Günther-Heinz Jähnick (talk) 18:02, 22 March 2017 (UTC)

I do not know what sortkey order I should use. It is at the moment: 1.UWT, 2.UWT, 1.HC, 2.HC, 1.1, 1.2, 2.1, 2.2, 1.Ncup, 2.Ncup, 1.2U, 2.2U, CC, CN, CDM, 1.WWT, 2.WWT That is done at line 60 (class_sort) at Module:Version 2. --Molarus 21:08, 27 March 2017 (UTC)

For men, it seems good, I have a doubt for Ncup and U23. For women, I ask the opinion of @Psemdel:. I think classes should be interlocked between mens and women as CDM, 1.UWT, 1.WWT, 2.UWT, 2.WWT, 1.HC, 2.HC, 1.1, 1.2, 2.1, 2.2, 1.Ncup, 2.Ncup, 1.2U, 2.2U, CC, CN. Jérémy-Günther-Heinz Jähnick (talk) 09:35, 29 March 2017 (UTC) PS : I was partly false, I found this at fr:Projet:Cyclisme/Usages#Victoires. Jérémy-Günther-Heinz Jähnick (talk) 10:08, 29 March 2017 (UTC)

Yes it should the same as for the men. This order is in everycase perfectly arbitrary, there is no need for a long debate. Psemdel (talk) 16:16, 29 March 2017 (UTC)

I have two items I do not see in the french table: CC (Q22231118, championnats continentaux) and CDM (Q23015458, Coupe du monde). On the other hand, I have no item for a "Championnats du monde" "CM" or is this CDM? Example race Q27150066), a "UCI ProTour (PT)" race and a Calendrier historique (HIS) race. I think, we have no items for the older races and therefore we will not see any data in the class column fo them. By the way, we do not print "WT", but 1.UWT, 1.WWT, 2.UWT, 2.WWT. Another point: In the french list for 2.HC there are different numbers: 03 and 5. I´m taking "03" as sorting key. --Molarus 16:38, 29 March 2017 (UTC)

It seems for Women races there is only "UCI World Tour féminin" available, see fr:Saison_2017_de_l'équipe_cycliste_Cervélo_Bigla#Victoires. Therefore only a WPlink to "UCI World Tour féminin 2017" is shown in the french article. Categories like 2.HC for women do not exist, instead items like "Calendrier international féminin UCI 2017" is added into the race items. We could use such an article as Wikipedia link target too, but we would have to create an item for "Calendrier international féminin UCI", I think, and add them into items like "Calendrier international féminin UCI 2017".

I have moved the new code to frwiki and it seems the code works. I think, now it is time to try to internationalize the victories table. I do not know how much time that will need, because more then testing the code and correcting errors is needed. --Molarus 01:46, 4 April 2017 (UTC)

I let @Psemdel: respond to these points, I am a little lost with these histories of classes.

Few points are again to solve, I have a look on fr:Modèle:Cycling race/victories. First case, if the race is recognized as a stage race thanks to its classes, we need to have general classification (Q691836) written before the comma or the article. By using an item for translations, it is a little more easy to acquire them. Second points, to display the championhips, the last points are the display of a short name, I use name (P2561) for New Zealand National Road Cycling Championships - Men ITT (Q22303252). This will permit to display all the translations we need. For the CN, we can make a link to 2017 national road cycling championships (Q28005879). Normally we always should have the correct way, even if there is a late in the development when we compare to other UCI races. I will see after for other points. Jérémy-Günther-Heinz Jähnick (talk) 09:10, 4 April 2017 (UTC)

I didn´t use the item to get the translations for "general classification". Since we already have in function victories_translate the translation for "Victories" (header of the table), it is no problem to add "general classification" too and users are used to this way. --Molarus 04:44, 5 April 2017 (UTC)

What is the question? Fpr the UCI Calendar, it is Q27765666 (if you want to link something to the 1.1 and so on). For the sorting, don't worry, it is imho not very important. Psemdel (talk) 07:00, 5 April 2017 (UTC)

Ok. Jérémy-Günther-Heinz Jähnick (talk) 18:58, 6 April 2017 (UTC)

I just have detected a little bug about championships. When we add the class CN as second value for instance of (P31), we lost the good display, see Module talk:Version 2 for the case of the USA. In my opinion, we should ignore CN (Q22231119) and CDM (Q23015458). Jérémy-Günther-Heinz Jähnick (talk) 10:23, 17 April 2017 (UTC)

Do you mean we should not display CD and CDM races anymore? The easiest solution for this is not to insert such races into the items.

About the problem: I think this is no error. I have updated frwiki, your last update was from 9. Avril. It do not work at Module Version 2 because items should have a property P2561 like Q22303252 and the USA item looks like this Q24731482 (rather empty). I had updated Module Version 2 to work for deWiki already some days ago. This way I know what I have to do to make the code work for all the other wikis too.

Sorry for not answering, I was not online at Wikidata due to a lack of motivation. --Molarus 23:20, 19 April 2017 (UTC)

No, I have problems to explain it in English. When we have an item for a championship where instance of (P31) has only one value, so the race, all works perfectly for the name. When we have two values, the natur of the race and its class, the system no longer works. So the idea is to "blacklist" classes as CN to avoid interferences (hard for me to explain). Psemdel says me that a problem occured with the last update, classement général is replaced by Victoires, see on fr:Modèle:Cycling race/victories. I guess it is just a detail. Classement général is just for stages races, when a team wins a single day race, it is always the general classification.

Idem, I also suffer from a lack of motivation. I am unable to go on races this year (surely the time of route), and to write articles. IRL, I am no longer motivated to work since march. I hope I will success to restart to work.

Yes, I do a test for championships and it works. I start little to little this work today. Jérémy-Günther-Heinz Jähnick (talk) 10:24, 21 April 2017 (UTC)

Hi, as I have already told Jérémy, I am using the function for all teams and found out some issues (no worry, we will correct them). As he said, now I get "victoire, Race... " for most of the races. But also I have a problem with all 2.2 from USA (yes sorry it is so), where the stages don't display. I get the issue for Tour of the Gila and here and also here for Tour of the Gila and Joe Martin Stage Race. For European 2.2 no problem, for instance here Psemdel (talk) 22:46, 21 April 2017 (UTC)

I think I have fixed both problems. Problem 1 was that I did not copy the new update for function victories_translate, but the second problem was more difficult. I think, the difference to the other races is that both races have no Wikipedia articles at all. In this case a fallback text was shown, which prints no stage data. @Psemdel: To shorten the text "Course en ligne féminine aux championnats de Nouvelle-Zélande de cyclisme sur route" at "Équipe cycliste UnitedHealthcare Women's" I have added at Q29061811 a name property. Could you check if the french is correct? Maybe you want a different text with "féminine" somewhere in the text. This example shows you to shorten similar long Championnat names. --Molarus 20:55, 22 April 2017 (UTC)

Many thanks for the corrections. As usually everything can be explained. There are articles but for the men races (in the USA, they always do both in parallel). For the name is there a difference between "P2561" and "P1448"? Is it read for all races (because actually I prefer without "féminine" everywhere, women can't race men races so there is no disambiguation requirement)? Psemdel (talk) 08:54, 23 April 2017 (UTC)

I guess, Jérémy wanted P2561 because it is no 'nom officiel' like the team name. The 'nom' of the championship is for one country only, but for all years. --Molarus 21:26, 23 April 2017 (UTC)

Yes, it is just a name, not an official name. Jérémy-Günther-Heinz Jähnick (talk) 14:47, 28 April 2017 (UTC)

Ok. I am quite happy with this new function. What is still disturbing me by the display are the "classement général" everywhere. For 2.x can I perfectly understand of course. But for one day race, it shouldn't be. The "if" is quite easy to do: everything that start with a "1" = no "classement général" needed. People judge the display. If it is beautiful, they consider using it. If they have too many contra, they will continue using the old way. Psemdel (talk) 19:36, 29 April 2017 (UTC)

I have changed the code at frWiki. Now only races with class 2.x show "Classement général,", the other do not. Software is similar to Wikipedia articles: More eyes see more problems. --Molarus 05:54, 30 April 2017 (UTC)

Many thanks, it looks good to me now. Psemdel (talk) 08:17, 30 April 2017 (UTC). Update, I thought to use the property name to delete the "women" everywhere in the name of the races. It doesn't work, but I understood why. In the code the name is read only for championship. Why?

if entity_type == 'championship' then a1, b1 = pcall(fooA, 'numeric-id', entity_race, 'P31', entity_num) if a1 == true then entity_l = mw.wikibase.getEntityObject( 'Q'..b1 ) a2, b2 = pcall(fooA, 'text', entity_l, 'P2561', 1) -- show the "name" if a2 == true then local lang_WD, text_WD for _,v in pairs(entity_l.claims["P2561"]) do lang_WD = v.mainsnak.datavalue.value.language text_WD = v.mainsnak.datavalue.value.text if wiki == lang_WD or wiki == 'www' then label_x =text_WD break end end end Psemdel (talk) 09:09, 30 April 2017 (UTC)

I´m not sure if I understand you. For example fr:Saison_2017_de_l'équipe_cycliste_féminine_Sunweb#Victoires shows "Circuit Het Nieuwsblad féminin" and the wikilink is to "Circuit Het Nieuwsblad féminin 2017", since this article exists. The label is taken from Q2973966. I guess, if you change the french label to "Circuit Het Nieuwsblad" maybe with "Circuit Het Nieuwsblad féminin" as alias label, that new text would be shown. By the way, at enWiki the name of the race would be shown as "Omloop Het Nieuwsblad – women's race". --Molarus 14:02, 2 May 2017 (UTC)

I have copied the code for the table from frwiki to WDwiki and added code that this table works only at frWiki and WDwiki (in function p.victories the code checks if wiki is Wikidata ('www') or frWiki). We have the same for references, which only works in enWiki, frWiki and deWiki. I think, the next step is to add code for more wikis, step by step. Maybe daWiki could be next? By the way, I have seen that function func_error_message has no french translation. You can see at Module talk:Version 2 a small error sign in the header of the table. If the mouse is on this sign the tooltip is shown, which says that the property x in item y is missing. At the moment only text written in english is shown. Could you add a french translation into function func_error_message? I like this new feature and maybe we could have this feature for more tables in the future. --Molarus 09:46, 9 May 2017 (UTC)

I rewrote completely the function, in order to avoid pcall and entity loading. The same functions as for calendar are used. I tested for FR, EN, DA, DE and it seems to be correct. I wanted to test for ES, but I can't create a module... For RU, how to say it, I can't read it. So try it yourself before implementing, sorry. It should display "exactly" the same as before, except that I don't display races without date. As most of the functions require the date (country for instance), it makes everything complicated. Moreover, it makes no sense to me. If we don't know the date of the race, it means that we know nothing and should not put it into wikidata. Psemdel (talk) 12:19, 3 October 2018 (UTC)

Cadel Evans Great Ocean Road Race 2017 (Q22977069) and Australia as best team with the function infobox

Hi Molarus. This morning I update this article, and I see we have a little problem to display just the name of the country for this best team : Australian men's national road cycling team 2017 (Q27927235). I don't know if the problem is new because I don't remember if we already have had a best team that was a national team. Jérémy-Günther-Heinz Jähnick (talk) 11:18, 29 January 2017 (UTC)

I don´t understand the problem. At fr:Cadel Evans Great Ocean Road Race 2017 "Meilleure équipe: Australia" is shown. What do you want to see in the infobox? --Molarus 17:51, 29 January 2017 (UTC)

Normaly, as for listofteams, we should have the algorithm that take the name of the country in the correct language. Here, we have Australia because I add in speed official name (P1448), but it is not good. If we have had Germany, the problem will be more visible. In french we say Australie. Jérémy-Günther-Heinz Jähnick (talk) 18:28, 1 February 2017 (UTC)

I hope, I have fixed it, without adding new errors into the code. That was really difficult. The new code is at frWiki and WDwiki. I have tested in frWiki some articles and it looks good, but it is still to early to be sure.

Now, in item Cadel Evans Great Ocean Road Race 2017 (Q22977069) the "best team" statement has a value for P54 "équipe d'Australie de cyclisme sur route 2017" too (as, for example, the "winner of the sprint classification"). It seems, without that P54 in the infobox no data is shown for the "best team", which is not optimal. I´m not sure if there is a solution without that additional P54.

It seems we had never before a national team as team winner. The reason was, I guess, we have dealt before only with U23 teams, which are not that good.

--Molarus 03:16, 3 February 2017 (UTC)

Yes, generally these teams have cyclist that are not the bests. I am a little lost with this P54. Jérémy-Günther-Heinz Jähnick (talk) 14:42, 4 February 2017 (UTC)

UCI-Id

Since 1-1-2017 each rider gets a new UCI-Id (link), maybe a new property. --Molarus 17:42, 29 January 2017 (UTC)

Yes. I will wait until the end of the week (I am not often at home in this moment). Jérémy-Günther-Heinz Jähnick (talk) 18:29, 1 February 2017 (UTC)